5.x - FIO-8426: changes required for eSignature #5633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Would like to get @brendanbond to take a look as well. |
brendanbond
reviewed
Jun 14, 2024
src/Webform.js
Outdated
| /** | ||
| * @param submission | ||
| * @param flags | ||
| * @return {void} |
There was a problem hiding this comment.
this is a HUGE nit, but the incoming PR from Travis will cause the linter to complain about this - can we get into the habit of adding descriptions and types for each (even any will do, although I have a JSON type in Form.js)?
| interactive: true, | ||
| content: this.t(this.sanitize(tooltipText), { _userInput: true }), | ||
| }); | ||
| this.tooltips[index] = this.createTooltip(tooltip); |
brendanbond
approved these changes
Jun 17, 2024
lane-formio
pushed a commit
that referenced
this pull request
Dec 9, 2024
* 5.x - FIO-8426: changes required for eSignature * added types and description * refactored types * added description for renderModalPreview returned value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8426
Description
What changed?
separated some code as new methods
Checklist: