Skip to content

Commit

Permalink
MODTLR-9 incorporating review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
roman-barannyk committed Jan 30, 2024
1 parent 65a3b9b commit 05ab601
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/main/java/org/folio/controller/EcsTlrController.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public ResponseEntity<EcsTlr> getEcsTlrById(UUID requestId) {

@Override
public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
log.debug("postEcsTlr:: parameters ecsTlr: {}", ecsTlr);
log.debug("postEcsTlr:: parameters ecsTlr: {}", () -> ecsTlr);

return ResponseEntity.status(CREATED).body(ecsTlrService.create(ecsTlr));
}
Expand All @@ -44,7 +44,7 @@ public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
log.debug("putEcsTlrById:: parameters requestId: {}, ecsTlr: {}", () -> requestId, () -> ecsTlr);
boolean requestUpdated = ecsTlrService.update(requestId, ecsTlr);
HttpStatus httpStatus = requestUpdated ? NO_CONTENT : NOT_FOUND;
HttpStatus httpStatus = requestUpdated ? NO_CONTENT : NOT_FOUND;

return ResponseEntity.status(httpStatus).build();
}
Expand All @@ -53,7 +53,7 @@ public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
public ResponseEntity<Void> deleteEcsTlrById(UUID requestId) {
log.debug("deleteEcsTlrById:: parameters requestId: {}", requestId);
boolean requestDeleted = ecsTlrService.delete(requestId);
HttpStatus httpStatus = requestDeleted ? NO_CONTENT : NOT_FOUND;
HttpStatus httpStatus = requestDeleted ? NO_CONTENT : NOT_FOUND;

return ResponseEntity.status(httpStatus).build();
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/resources/swagger.api/examples/EcsTlr.sample
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"requesterId": "4565999e-1994-4aab-9282-185731b4ce66",
"requestType": "Hold",
"requestLevel": "Title",
"requestExpirationDate": "2024-01-01T23:11:00-00:00",
"requestDate": "2024-01-01T00:12:00-00:00"
"requestExpirationDate": "2024-01-01T23:11:00+00:00",
"requestDate": "2024-01-01T00:12:00+00:00"
"patronComments": "test comment",
"fulfillmentPreference": "Hold Shelf",
"pickupServicePointId": "71ff4b72-70a0-40f6-9f73-6db29ced80a3"
Expand Down

0 comments on commit 05ab601

Please sign in to comment.