MODTLR-9 incorporating review comments

folio-org · Jan 30, 2024 · 65a3b9b · 65a3b9b
1 parent 12c1125
commit 65a3b9b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/org/folio/controller/EcsTlrController.java b/src/main/java/org/folio/controller/EcsTlrController.java
@@ -43,15 +43,17 @@ public ResponseEntity<EcsTlr> postEcsTlr(EcsTlr ecsTlr) {
   @Override
   public ResponseEntity<Void> putEcsTlrById(UUID requestId, EcsTlr ecsTlr) {
     log.debug("putEcsTlrById:: parameters requestId: {}, ecsTlr: {}", () -> requestId, () -> ecsTlr);
-    HttpStatus httpStatus = ecsTlrService.update(requestId, ecsTlr) ? NO_CONTENT : NOT_FOUND;
+    boolean requestUpdated = ecsTlrService.update(requestId, ecsTlr);
+    HttpStatus httpStatus = requestUpdated  ? NO_CONTENT : NOT_FOUND;
 
     return ResponseEntity.status(httpStatus).build();
   }
 
   @Override
   public ResponseEntity<Void> deleteEcsTlrById(UUID requestId) {
     log.debug("deleteEcsTlrById:: parameters requestId: {}", requestId);
-    HttpStatus httpStatus = ecsTlrService.delete(requestId) ? NO_CONTENT : NOT_FOUND;
+    boolean requestDeleted = ecsTlrService.delete(requestId);
+    HttpStatus httpStatus = requestDeleted  ? NO_CONTENT : NOT_FOUND;
 
     return ResponseEntity.status(httpStatus).build();
   }

diff --git a/src/main/resources/swagger.api/examples/EcsTlr.sample b/src/main/resources/swagger.api/examples/EcsTlr.sample
@@ -4,8 +4,8 @@
     "requesterId": "4565999e-1994-4aab-9282-185731b4ce66",
     "requestType": "Hold",
     "requestLevel": "Title",
-    "requestExpirationDate": "2024-01-01T23:11:00-01:00",
-    "requestDate": "2024-01-01T00:12:00-01:00"
+    "requestExpirationDate": "2024-01-01T23:11:00-00:00",
+    "requestDate": "2024-01-01T00:12:00-00:00"
     "patronComments": "test comment",
     "fulfillmentPreference": "Hold Shelf",
     "pickupServicePointId": "71ff4b72-70a0-40f6-9f73-6db29ced80a3"