job-archive: remove module #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops - looks like there are still some flux-accounting tests that rely on this.
|
|
How about adding to the commit message that this fixes ... #5288 |
cmoussa1
added a commit
to cmoussa1/flux-accounting
that referenced
this pull request
Oct 17, 2024
Problem: t1011-job-archive-interface.t relies on the job-archive module in flux-core which is being considered for removal in flux-framework/flux-core#6378 since flux-accounting now has that capability on its own. Add a check in t1011-job-archive-interface.t that will skip the tests in the event that the job-archive module does not exist.
cmoussa1
added a commit
to cmoussa1/flux-accounting
that referenced
this pull request
Oct 17, 2024
Problem: t1011-job-archive-interface.t relies on the job-archive module in flux-core which is being considered for removal in flux-framework/flux-core#6378 since flux-accounting now has that capability on its own. Add a check in t1011-job-archive-interface.t that will skip the tests in the event that the job-archive module does not exist.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6378 +/- ##
==========================================
+ Coverage 83.29% 83.55% +0.26%
==========================================
Files 524 523 -1
Lines 86230 87348 +1118
==========================================
+ Hits 71826 72985 +1159
+ Misses 14404 14363 -41 |
cmoussa1
added a commit
to cmoussa1/flux-accounting
that referenced
this pull request
Oct 17, 2024
Problem: t1011-job-archive-interface.t relies on the job-archive module in flux-core which is being considered for removal in flux-framework/flux-core#6378 since flux-accounting now has that capability on its own. Edit the tests that use the job-archive module and just use flux-accounting's fetch-job-records script to fetch inactive job records.
Problem: the job archive module is no longer needed now that flux-accounting maintains its own historical job record internally. Remove job-archive, its tests, and its documentation. Fixes flux-framework#5288
|
Just force pushed after rebasing on current master and caching a couple of dangling man page references in the docs. Will set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not needed anymore