Skip to content

Commit

Permalink
job-archive: remove module
Browse files Browse the repository at this point in the history
Problem: the job archive module is no longer needed now that
flux-accounting maintains its own historical job record internally.

Remove job-archive, its tests, and its documentation.

Fixes #5288
  • Loading branch information
garlick committed Oct 28, 2024
1 parent 92a3f28 commit 926ff71
Show file tree
Hide file tree
Showing 12 changed files with 4 additions and 1,089 deletions.
1 change: 0 additions & 1 deletion doc/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ MAN5_FILES_PRIMARY = \
man5/flux-config-exec.5 \
man5/flux-config-systemd.5 \
man5/flux-config-resource.5 \
man5/flux-config-archive.5 \
man5/flux-config-job-manager.5 \
man5/flux-config-ingest.5 \
man5/flux-config-kvs.5 \
Expand Down
4 changes: 1 addition & 3 deletions doc/guide/admin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ Example file installed path: ``/etc/flux/system/conf.d/system.toml``
See also: :man5:`flux-config-exec`, :man5:`flux-config-access`
:man5:`flux-config-bootstrap`, :man5:`flux-config-tbon`,
:man5:`flux-config-resource`, :man5:`flux-config-ingest`,
:man5:`flux-config-archive`, :man5:`flux-config-job-manager`,
:man5:`flux-config-job-manager`,
:man5:`flux-config-policy`, :man5:`flux-config-kvs`,
:sched:man5:`flux-config-sched-fluxion-qmanager`,
:sched:man5:`flux-config-sched-fluxion-resource`.
Expand Down Expand Up @@ -660,8 +660,6 @@ restarts.

The ``statedir`` directory is used for the ``content.sqlite`` file that
contains content addressable storage backing the Flux key value store (KVS).
The ``job-archive.sqlite`` file is also located there, if job archival is
enabled.

Adding Job Prolog/Epilog Scripts
================================
Expand Down
55 changes: 0 additions & 55 deletions doc/man5/flux-config-archive.rst

This file was deleted.

4 changes: 2 additions & 2 deletions doc/man5/flux-config-job-manager.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ inactive-age-limit
(optional) String (in RFC 23 Flux Standard Duration format) that specifies
the maximum age of inactive jobs retained in the KVS. The age is computed
since the job became inactive. Once a job is removed from the KVS, its job
data is only available via the job-archive, if configured. Inactive jobs
can also be manually purged with :man1:`flux-job` ``purge``.
data is not longer available. Inactive jobs can also be manually purged
with :man1:`flux-job` ``purge``.

inactive-num-limit
(optional) Integer maximum number of inactive jobs retained in the KVS.
Expand Down
2 changes: 1 addition & 1 deletion doc/man5/flux-config.rst
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ SEE ALSO

:man1:`flux-broker`, :man5:`flux-config-access`, :man5:`flux-config-bootstrap`,
:man5:`flux-config-tbon`, :man5:`flux-config-exec`, :man5:`flux-config-ingest`,
:man5:`flux-config-resource`, :man5:`flux-config-archive`,
:man5:`flux-config-resource`,
:man5:`flux-config-job-manager`, :man5:`flux-config-kvs`
1 change: 0 additions & 1 deletion doc/manpages.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,6 @@
('man5/flux-config-systemd', 'flux-config-systemd', 'configure Flux systemd support', [author], 5),
('man5/flux-config-ingest', 'flux-config-ingest', 'configure Flux job ingest service', [author], 5),
('man5/flux-config-resource', 'flux-config-resource', 'configure Flux resource service', [author], 5),
('man5/flux-config-archive', 'flux-config-archive', 'configure Flux job archival service', [author], 5),
('man5/flux-config-policy', 'flux-config-policy', 'configure Flux job policy', [author], 5),
('man5/flux-config-queues', 'flux-config-queues', 'configure Flux job queues', [author], 5),
('man5/flux-config-job-manager', 'flux-config-job-manager', 'configure Flux job manager service', [author], 5),
Expand Down
4 changes: 0 additions & 4 deletions etc/rc1
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ modload 0 cron sync=heartbeat.pulse
modload 0 job-manager
modload all job-info
modload 0 job-list
period=`flux config get --default= archive.period`
if test $RANK -eq 0 -a -n "${period}"; then
flux module load job-archive
fi

if test $RANK -eq 0; then
if test "$(backing_module)" != "none"; then
Expand Down
1 change: 0 additions & 1 deletion etc/rc3
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ done
modrm 0 heartbeat
modrm 0 sched-simple
modrm all resource
modrm 0 job-archive
modrm 0 job-exec
modrm 0 job-list
modrm all job-info
Expand Down
14 changes: 0 additions & 14 deletions src/modules/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ fluxmod_LTLIBRARIES = \
content-sqlite.la \
cron.la \
heartbeat.la \
job-archive.la \
job-exec.la \
job-info.la \
job-list.la \
Expand Down Expand Up @@ -137,19 +136,6 @@ heartbeat_la_LIBADD = \
$(top_builddir)/src/common/libflux-core.la
heartbeat_la_LDFLAGS = $(fluxmod_ldflags) -module

job_archive_la_SOURCES = \
job-archive/job-archive.c
job_archive_la_CPPFLAGS = \
$(AM_CPPFLAGS) \
$(SQLITE_CFLAGS) \
$(FLUX_SECURITY_CFLAGS)
job_archive_la_LIBADD = \
$(top_builddir)/src/common/libflux-internal.la \
$(top_builddir)/src/common/libflux-core.la \
$(JANSSON_LIBS) \
$(SQLITE_LIBS)
job_archive_la_LDFLAGS = $(fluxmod_ldflags) -module

job_exec_la_SOURCES =
job_exec_la_LIBADD = \
$(builddir)/job-exec/libjob-exec.la \
Expand Down
Loading

0 comments on commit 926ff71

Please sign in to comment.