view-job-records: accept multiple timestamp formats for after-start-time, before-end-time optional args
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The --after-start-time and --before-end-time optional args for the view-job-records command only takes one format: a seconds-since-epoch timestamp, which isn't super user friendly. Utilize flux.util.parse_datetime() to accept multiple, more human-readable format strings as values to the --after-start-time and --before-end-time optional args. Add a helper function to jobs_table_subcommands to perform the parsing of the string. If parsing the timestamp string fails, just attempt to pass it as a seconds-since-epoch timestamp (which will return no job records if the timestamp is invalid).
Problem: The view-job-records command help description is not clear in what formats it accepts for timestamps for the after-start-time and before-end-time optional arguments. Extend the help descriptions for both of these optional arguments and provide examples of acceptable human-readable formats.
Problem: There exists no sharness tests for passing different timestamp formats for the --after-start-time and --before-end-time optional arguments for the view-job-records command. Add some basic tests.
cmoussa1
added
improvement
jameshcorbett
approved these changes
Jan 27, 2025
|
Thanks! I'll set MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
--after-start-timeand--before-end-timeoptional args for theview-job-recordscommand only takes one format: a seconds-since-epoch timestamp, which isn't super user friendly.This PR makes use of the
flux.util.parse_datetime()function to accept multiple, more human-readable format strings as values to the--after-start-timeand--before-end-timeoptional args.It adds a helper function to
jobs_table_subcommandsto perform the parsing of the timestamp. If parsing the timestamp string fails, it just attempts to pass it as a seconds-since-epoch timestamp to the SQLite query (which will return no job records if the timestamp is invalid).I've also updated the help description to both of the optional arguments to provide examples of human-readable formats as well as added some basic sharness tests that pass different timestamp formats to the flux-accounting job-archive.
Fixes #565