view-job-records --jobid: accept all Flux job ID formats
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
added
improvement
As noted in flux-framework#564, viewing a job record with view-job-records --jobid only accepts decimal formats of job IDs. However, Flux offers multiple formats for Job IDs, and thus, the --jobid argument should also be able to handle such formats. Use the flux.job.JobID() class to convert any Flux job ID format to a decimal format when looking up a job record in the flux-accounting job-archive.
Problem: There are no tests for calling view-job-records --jobid where the format of --jobid is in multiple formats, such as f58, hex, dothex, etc. Add some basic tests.
ryanday36
approved these changes
Jan 27, 2025
|
Thanks @ryanday36! I just rebased to catch up after #567. Will set MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #564, viewing a job record with
view-job-records --jobidonly accepts decimal formats of job IDs. However, Flux offers multiple formats for job IDs, and thus, the--jobidargument should also be able to handle such formats.This PR adds the use of the
flux.job.JobID()class to convert any Flux job ID format passed-in to a decimal format when looking up a job record in the flux-accounting job-archive.I've also added in some basic tests that call
view-job-records --jobidwith different ID formats.Fixes #564