-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds kind
to RunTx, and SpamTx Plan
#30
Merged
+90
−23
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d83ab85
add name() method to FunctionCallDefinition
jinmel 545e842
nit: unwrap Option in println
jinmel 44d23ec
remove duplicate print
jinmel f2b30e0
Merge remote-tracking branch 'origin/main' into higher-throughput
jinmel 142cff5
add regex crate
jinmel f90fdb5
add `kind` to FunctionCallDef
jinmel 3bbf1e6
add kind to db
jinmel 3078381
remove name() method from FunctionCallDefinition
jinmel ae04b7c
simplifies the test config toml file
jinmel 81a5cb2
remove regex from packages def
jinmel d93b683
use mutable refence to tx for set_kind()
jinmel da65b15
use Option<String> type for kind across the stack
jinmel 2395502
Merge remote-tracking branch 'origin/main' into higher-throughput
jinmel 1e091e1
remove insert_run_tx
jinmel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use Option<String> type for kind across the stack
commit da65b15bfa8ed211b5e0d4ff782500fcc9a062b1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change this to
kind: Option<&str>
-- that way the user can call it withSome("kind")