adds kind to RunTx, and SpamTx Plan
#30
Conversation
jinmel
force-pushed
the
higher-throughput
branch
from
2548563 to
44d23ec
Compare
jinmel
force-pushed
the
higher-throughput
branch
from
477c9b3 to
3078381
Compare
| assert_eq!(spam[0].fuzz.as_ref().unwrap()[0].param, "amountIn"); | ||
| assert_eq!( |
There was a problem hiding this comment.
this assertion (or something similar) should still be in here
There was a problem hiding this comment.
I modified the config toml so that we are unit testing a small, easily understandable file. check the testConfig.toml I wrote.
There was a problem hiding this comment.
yeah I just mean we should continue to test the fuzz params using that file. This test was just deleted but it doesn't have to be.
| println!("contract address: {:?}", receipt.contract_address | ||
| .as_ref() | ||
| .map(|a| a.encode_hex()) | ||
| .unwrap_or("".to_string())); |
There was a problem hiding this comment.
does unwrap_or_default work here?
There was a problem hiding this comment.
says default trait is not implemented
There was a problem hiding this comment.
Default is implemented for String, might just be a syntax issue
| pub fn with_name(name: &str, tx: TransactionRequest) -> Self { | ||
| Self { | ||
| name: Some(name.to_string()), | ||
| kind: None, | ||
| tx, | ||
| } | ||
| } | ||
|
|
||
| pub fn set_kind(&mut self, kind: String) { | ||
| self.kind = Some(kind); | ||
| } |
There was a problem hiding this comment.
I think this all should just be swapped out for a new constructor.
impl NamedTxRequest {
pub fn new(tx: TransactionRequest, name: Option<&str>, kind: Option<&str>) -> Self {...}
}This is more idiomatic, and we don't have any reason to iteratively build the struct in our code in the first place.
| } | ||
|
|
||
| impl PendingRunTx { | ||
| pub fn new(tx_hash: TxHash, start_timestamp: usize) -> Self { | ||
| pub fn new(tx_hash: TxHash, start_timestamp: usize, kind: Option<String>) -> Self { |
There was a problem hiding this comment.
I'd change this to kind: Option<&str> -- that way the user can call it with Some("kind")
No description provided.