upgrade-snapshot-tests-dependency-fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2024 11:24
bstien
reviewed
Jan 9, 2024
| @@ -149,7 +149,7 @@ extension XCTestCase { | |||
| line: UInt | |||
| ) { | |||
| UIView.setAnimationsEnabled(false) | |||
| let subpixelThreshold: UInt8 = 5 | |||
| let perceptualPrecision: Float = 5 | |||
There was a problem hiding this comment.
This value should be between 0 and 1. What we should do here in try to find the sweet-spot where CircleCI does not fail our tests in neither FinniversKit nor FinnUI.
The comments seems to point to 0.98 being a reasonable value, but please test this before merging this PR
There was a problem hiding this comment.
that's correct!
i looked instead at these:
|
based on research from here: pointfreeco/swift-snapshot-testing#628
|
adriansergheev
force-pushed
the
upgrade-snapshot-tests-dependency
branch
3 times, most recently
from
f09cb59 to
4519df8
Compare
adriansergheev
force-pushed
the
upgrade-snapshot-tests-dependency
branch
from
4519df8 to
b7dd1a0
Compare
adriansergheev
force-pushed
the
upgrade-snapshot-tests-dependency
branch
from
f51f726 to
19ab879
Compare
bstien
approved these changes
Jan 16, 2024
adriansergheev
pushed a commit
that referenced
this pull request
Jan 25, 2024
This reverts commit de28e39.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4