upgrade-snapshot-tests-dependency-fix (#5)

* fix * re-enable perceptualPrecision * wip * 0.98->0.95 * precision * try 0.98 for precision * pass precision, percpetualPrecision as parameters --------- Co-authored-by: Adrian Sergheev <[email protected]>
finn-no · Jan 17, 2024 · de28e39 · de28e39
1 parent 002558c
commit de28e39
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/Sources/DemoKitSnapshot/XCTestCase+Extensions.swift b/Sources/DemoKitSnapshot/XCTestCase+Extensions.swift
@@ -34,6 +34,9 @@ extension XCTestCase {
     public func snapshotTest(
         demoable: any Demoable,
         record: Bool = false,
+        // https://github.com/pointfreeco/swift-snapshot-testing/pull/628#issuecomment-1256363278
+        precision: Float = 0.98,
+        perceptualPrecision: Float = 0.98,
         file: StaticString = #file,
         line: UInt = #line
     ) {
@@ -50,8 +53,10 @@ extension XCTestCase {
                 performSnapshots(
                     viewController: viewController,
                     record: record,
-                    testName: demoable.identifier,
+                    testName: demoable.identifier, 
                     tweakName: tweak.testName,
+                    precision: precision,
+                    perceptualPrecision: perceptualPrecision,
                     file: file,
                     line: line
                 )
@@ -61,6 +66,8 @@ extension XCTestCase {
                 viewController: viewController,
                 record: record,
                 testName: demoable.identifier,
+                precision: precision,
+                perceptualPrecision: perceptualPrecision,
                 file: file,
                 line: line
             )
@@ -145,11 +152,12 @@ extension XCTestCase {
         record: Bool,
         testName: String,
         tweakName: String? = nil,
+        precision: Float = 0.98,
+        perceptualPrecision: Float = 0.98,
         file: StaticString,
         line: UInt
     ) {
         UIView.setAnimationsEnabled(false)
-        let subpixelThreshold: UInt8 = 5
         let userInterfaceStyle: [UIUserInterfaceStyle] = [.light, .dark]
 
         userInterfaceStyle.forEach { userInterfaceStyle in
@@ -165,7 +173,8 @@ extension XCTestCase {
                     matching: viewController,
                     as: .image(
                         on: device.imageConfig,
-                        subpixelThreshold: subpixelThreshold,
+                        precision: precision,
+                        perceptualPrecision: perceptualPrecision,
                         traits: traits
                     ),
                     named: name,