Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): Format long type examples #4544

Merged
merged 5 commits into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions generators/go/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
.PHONY: build
build:
docker build -f ./docker/Dockerfile.model -t fernapi/fern-go-model .
docker build -f ./docker/Dockerfile.sdk -t fernapi/fern-go-sdk .
docker build -f ./docker/Dockerfile.fiber -t fernapi/fern-go-fiber .
docker build -f ./model/Dockerfile -t fernapi/fern-go-model .
docker build -f ./sdk/Dockerfile -t fernapi/fern-go-sdk .
docker build -f ./fiber/Dockerfile -t fernapi/fern-go-fiber .
docker tag fernapi/fern-go-sdk fernapi/fern-go-sdk:0.0.0

.PHONY: generate
Expand Down
2 changes: 1 addition & 1 deletion generators/go/internal/generator/snippet.go
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ func (s *SnippetWriter) getSnippetForPrimitive(
}
case "long":
return &ast.BasicLit{
Value: strconv.FormatInt(exampleTypeReference.Long, 64),
Value: strconv.FormatInt(exampleTypeReference.Long, 10),
}
case "datetime":
return &ast.CallExpr{
Expand Down
8 changes: 8 additions & 0 deletions generators/go/sdk/versions.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
- version: 0.23.5
created_at: '2024-09-05'
changelog_entry:
- type: fix
summary: >-
Fix an issue where `long` type examples (generated as `int64` in Go) were not
successfully converted to their equivalent `string` representation for snippets.
ir_version: 40
- version: 0.23.4
created_at: '2024-08-30'
changelog_entry:
Expand Down
2 changes: 2 additions & 0 deletions seed/csharp-model/examples/.mock/definition/types.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions seed/csharp-model/examples/src/SeedExamples/Types/Movie.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions seed/csharp-sdk/examples/no-custom-config/reference.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion seed/csharp-sdk/examples/no-custom-config/snippet.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions seed/csharp-sdk/examples/readme-config/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions seed/csharp-sdk/examples/readme-config/reference.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion seed/csharp-sdk/examples/readme-config/snippet.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/fastapi/examples/.mock/definition/types.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/fastapi/examples/resources/types/types/movie.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/go-fiber/examples/.mock/definition/types.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/go-fiber/examples/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/go-model/examples/.mock/definition/types.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/go-model/examples/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion seed/go-sdk/examples/no-custom-config/snippet.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions seed/go-sdk/examples/no-custom-config/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading