Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): Format long type examples #4544

Merged
merged 5 commits into from
Sep 5, 2024
Merged

fix(go): Format long type examples #4544

merged 5 commits into from
Sep 5, 2024

Conversation

amckinney
Copy link
Member

This fixes an issue where long type examples (generated as int64 in Go) were not successfully converted to their equivalent string representation for snippets. This also adds a simple long type to the examples test definition to verify the behavior.

@amckinney amckinney requested a review from dsinghvi as a code owner September 5, 2024 16:34
@amckinney amckinney merged commit ae8cb13 into main Sep 5, 2024
38 checks passed
@amckinney amckinney deleted the amckinney/go/snippet branch September 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amckinney @dsinghvi