Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show custom status code field in API docs #833

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { CodeSnippetExample } from "../examples/CodeSnippetExample";
import { JsonPropertyPath } from "../examples/JsonPropertyPath";
import type { CodeExample, CodeExampleGroup } from "../examples/code-example";
import { lineNumberOf } from "../examples/utils";
import { getSuccessMessageForStatus } from "../utils/getSuccessMessageForStatus";
import { CodeExampleClientDropdown } from "./CodeExampleClientDropdown";
import { EndpointUrlWithOverflow } from "./EndpointUrlWithOverflow";
import { ErrorCodeSnippetExample } from "./ErrorCodeSnippetExample";
Expand Down Expand Up @@ -110,11 +111,24 @@ const UnmemoizedEndpointContentCodeSnippets: React.FC<EndpointContentCodeSnippet
}
/>
{endpoint.responseBody?.shape.type === "fileDownload" && <AudioExample title="Response" />}

{example.responseBody != null &&
endpoint.responseBody?.shape.type !== "fileDownload" &&
(selectedError == null ? (
<CodeSnippetExample
title={"Response"}
title={
<div className="text-sm px-1 t-muted">
Response -{" "}
<span className="text-intent-success">
{endpoint.responseBody?.statusCode +
" " +
getSuccessMessageForStatus(
endpoint.responseBody?.statusCode as number,
endpoint.method,
)}
</span>
</div>
}
onClick={(e) => {
e.stopPropagation();
}}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
type StatusCodeMessages = {
[method: string]: string;
};

type SuccessMessages = {
[code: number]: StatusCodeMessages;
};

export const COMMON_SUCCESS_NAMES: SuccessMessages = {
200: {
PUT: "Updated",
DELETE: "Deleted",
default: "Success",
},
201: {
PUT: "Updated",
default: "Created",
},
202: {
default: "Accepted",
},
203: {
default: "Non-Authoritative Information",
},
204: {
default: "No Content",
},
205: {
default: "Reset Content",
},
206: {
default: "Partial Content",
},
207: {
default: "Multi-Status",
},
208: {
default: "Already Reported",
},
226: {
default: "IM Used",
},
};

export function getSuccessMessageForStatus(statusCode: number, method: string): string {
const messages = COMMON_SUCCESS_NAMES[statusCode];
if (!messages) {
return "Success";
}
return messages[method] ?? messages.default;
}
2 changes: 1 addition & 1 deletion packages/ui/app/src/resolver/ApiDefinitionResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ export class ApiDefinitionResolver {
this.resolveResponseBodyShape(response.type),
maybeSerializeMdxContent(response.description),
]);
return { shape, description, availability: undefined };
return { shape, description, statusCode: response?.statusCode ?? 200, availability: undefined };
}

// HACKHACK: this handles the case where FernIR is unable to interpret the security scheme for AsyncAPI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ exports[`resolveApiDefinition > should finish resolving 1`] = `
},
"type": "list",
},
"statusCode": 200,
},
"slug": [
"merchants",
Expand Down
1 change: 1 addition & 0 deletions packages/ui/app/src/resolver/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ export interface ResolvedObjectProperty extends WithMetadata {

export interface ResolvedResponseBody extends WithMetadata {
shape: ResolvedHttpResponseBodyShape;
statusCode: number;
}

export type ResolvedEndpointPathParts = ResolvedEndpointPathParts.Literal | ResolvedEndpointPathParts.PathParameter;
Expand Down
Loading