Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show custom status code field in API docs #833

Conversation

KenzoBenzo
Copy link
Contributor

@KenzoBenzo KenzoBenzo commented May 9, 2024

Fixes FER-1667 — the UI PR for #828

Short description of the changes made

Now rendering the custom status code for a response. Note: this is on ALL docs, not feature flagged.

image

What was the motivation & context behind this PR?

This is a blocker for Kard's development on Fern.

How has this PR been tested?'

Double checked responsiveness + Visually using:

  • kardfinancial.docs.buildwithfern.com
  • fern.docs.buildwithfern.com
  • hume.docs.buildwithfern.com

@KenzoBenzo KenzoBenzo self-assigned this May 9, 2024
Copy link

linear bot commented May 9, 2024

FER-1667 [Kard] Show custom `status-code` field in the docs

#828 FDR now stores a response status code that isn't 200. Fern docs needs to show this response status code (and default to 200 when it is not present).

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 9, 2024 5:02pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 9, 2024 5:02pm
fontawesome-cdn ⬜️ Ignored (Inspect) May 9, 2024 5:02pm
private-docs ⬜️ Ignored (Inspect) May 9, 2024 5:02pm

@KenzoBenzo KenzoBenzo marked this pull request as ready for review May 9, 2024 16:57
@KenzoBenzo KenzoBenzo requested a review from abvthecity as a code owner May 9, 2024 16:57
@KenzoBenzo KenzoBenzo enabled auto-merge (squash) May 9, 2024 16:57
@KenzoBenzo KenzoBenzo merged commit 7ecfa21 into main May 9, 2024
20 checks passed
@KenzoBenzo KenzoBenzo deleted the makenna/fer-1667-kard-show-custom-status-code-field-in-the-docs branch May 9, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants