-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show custom status code field in API docs #833
Merged
KenzoBenzo
merged 4 commits into
main
from
makenna/fer-1667-kard-show-custom-status-code-field-in-the-docs
May 9, 2024
Merged
feat: show custom status code field in API docs #833
KenzoBenzo
merged 4 commits into
main
from
makenna/fer-1667-kard-show-custom-status-code-field-in-the-docs
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FER-1667 [Kard] Show custom `status-code` field in the docs
#828 FDR now stores a response status code that isn't 200. Fern docs needs to show this response status code (and default to |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e-field-in-the-docs
dsinghvi
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-1667 — the UI PR for #828
Short description of the changes made
Now rendering the custom status code for a response. Note: this is on ALL docs, not feature flagged.
What was the motivation & context behind this PR?
This is a blocker for Kard's development on Fern.
How has this PR been tested?'
Double checked responsiveness + Visually using: