Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: request response snippet resolver should work for endpoint pairs (stream/batch) #1818

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Nov 15, 2024

Before this PR: the request/response snippet selector will ignore endpoint pairs, always selecting the first encountered endpoint (usually stream, not batch)

After this PR: the request/response snippet selector will consider the provided example name when selecting for the relevant endpoint

Also in this PR

  • fix regression in rendering basepath in endpoint snippet title
  • restore backlink to api reference

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 15, 2024 4:12pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 15, 2024 4:12pm

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  97 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 18 seconds
commit  4287b0e

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 21848dd into main Nov 15, 2024
19 of 20 checks passed
@abvthecity abvthecity deleted the ajiang/fix-request-response-snipet branch November 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants