Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basepath regression #1819

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: basepath regression #1819

merged 1 commit into from
Nov 15, 2024

Conversation

abvthecity
Copy link
Contributor

regression introduced in #1818 was adding an additional / to the beginning of each endpoint

@abvthecity abvthecity marked this pull request as ready for review November 15, 2024 19:58
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 15, 2024 7:58pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 15, 2024 7:58pm

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  96 passed
flaky  2 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 37 seconds
commit  88e36fb

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 7a9205c into main Nov 15, 2024
19 of 20 checks passed
@abvthecity abvthecity deleted the ajiang/fix-basepath-issue branch November 15, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants