Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update fdr types to accomodate extra properties type reference #1611

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

RohinBhargava
Copy link
Member

Fixes FER-3361

Short description of the changes made

  • Adds extraProperties to ObjectType in fdr, which allows the plumbing of a value type for Map<string, valueType> for use with UI downstream
  • extraProperties is typed as an optional<TypeReference>, since it is either a discrete shape, or Unknown type (both handled by existing visitors in UI

What was the motivation & context behind this PR?

  • Product Demo

How has this PR been tested?

WIP to be pushed to FDR dev for testing

Copy link

github-actions bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9 seconds
commit  9b89569

Copy link

github-actions bot commented Oct 8, 2024

PR Preview

Copy link

github-actions bot commented Oct 8, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.54 KB (🟢 -94.74 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 332 B 162.87 KB 46.53%

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/dynamic/[host]/[[...slug]] 55.51 KB 218.05 KB 62.30% (🟢 -6.17%)
/static/[host]/[[...slug]] 55.51 KB 218.05 KB 62.30% (🟢 -6.17%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link

github-actions bot commented Oct 8, 2024

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 13 seconds
commit  9b89569

@RohinBhargava RohinBhargava marked this pull request as ready for review October 8, 2024 18:50
Copy link

github-actions bot commented Oct 8, 2024

@RohinBhargava RohinBhargava changed the title wip: updated fdr types to accomodate extra property type reference feat: updated fdr types to accomodate extra properties type reference Oct 8, 2024
@RohinBhargava RohinBhargava changed the title feat: updated fdr types to accomodate extra properties type reference feat: update fdr types to accomodate extra properties type reference Oct 8, 2024
@RohinBhargava RohinBhargava enabled auto-merge (squash) October 8, 2024 18:51
Copy link

github-actions bot commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants