feat: update fdr types to accomodate extra properties type reference (#…

…1611)
fern-api · Oct 8, 2024 · 974bc61 · 974bc61
1 parent 389e723
commit 974bc61
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 0 deletions.
diff --git a/fern/apis/fdr/definition/api/latest/type.yml b/fern/apis/fdr/definition/api/latest/type.yml
@@ -52,6 +52,7 @@ types:
     properties:
       extends: list<rootCommons.TypeId>
       properties: list<ObjectProperty>
+      extraProperties: optional<TypeReference>
 
   ObjectProperty:
     extends:

diff --git a/packages/fdr-sdk/src/api-definition/__test__/unwrap.test.ts b/packages/fdr-sdk/src/api-definition/__test__/unwrap.test.ts
@@ -291,6 +291,7 @@ describe("unwrapObjectType", () => {
                     availability: undefined,
                 },
             ],
+            extraProperties: undefined,
         };
 
         expect(unwrapObjectType(shape, {}).properties.map((p) => p.key)).toStrictEqual([
@@ -323,6 +324,7 @@ describe("unwrapObjectType", () => {
                     availability: undefined,
                 },
             ],
+            extraProperties: undefined,
         };
         const types: Record<TypeId, TypeDefinition> = {
             [TypeId("b")]: {
@@ -338,6 +340,7 @@ describe("unwrapObjectType", () => {
                             availability: undefined,
                         },
                     ],
+                    extraProperties: undefined,
                 },
                 description: undefined,
                 availability: undefined,
@@ -355,6 +358,7 @@ describe("unwrapObjectType", () => {
                             availability: undefined,
                         },
                     ],
+                    extraProperties: undefined,
                 },
                 description: undefined,
                 availability: undefined,
@@ -380,6 +384,7 @@ describe("unwrapObjectType", () => {
                     availability: undefined,
                 },
             ],
+            extraProperties: undefined,
         };
         const types: Record<TypeId, TypeDefinition> = {
             [TypeId("b")]: {
@@ -422,6 +427,7 @@ describe("unwrapObjectType", () => {
                             availability: undefined,
                         },
                     ],
+                    extraProperties: undefined,
                 },
                 description: "description-2",
                 availability: undefined,

diff --git a/packages/fdr-sdk/src/api-definition/migrators/v1ToV2.ts b/packages/fdr-sdk/src/api-definition/migrators/v1ToV2.ts
@@ -280,6 +280,7 @@ export class ApiDefinitionV1ToLatest {
                 type: "object",
                 extends: value.extends,
                 properties: this.migrateObjectProperties(value.properties),
+                extraProperties: undefined,
             }),
             alias: (value) => ({
                 type: "alias",
@@ -305,6 +306,7 @@ export class ApiDefinitionV1ToLatest {
                     availability: variant.availability,
                     extends: variant.additionalProperties.extends,
                     properties: this.migrateObjectProperties(variant.additionalProperties.properties),
+                    extraProperties: undefined,
                 })),
             }),
         });
@@ -483,6 +485,7 @@ export class ApiDefinitionV1ToLatest {
                     type: "object",
                     extends: value.extends,
                     properties: this.migrateObjectProperties(value.properties),
+                    extraProperties: undefined,
                 }),
                 reference: (value) => ({
                     type: "alias",
@@ -519,6 +522,7 @@ export class ApiDefinitionV1ToLatest {
                     type: "object",
                     extends: value.extends,
                     properties: this.migrateObjectProperties(value.properties),
+                    extraProperties: undefined,
                 }),
                 reference: (value) => ({
                     type: "alias",

diff --git a/...rc/client/generated/api/resources/api/resources/latest/resources/type/types/ObjectType.ts b/...rc/client/generated/api/resources/api/resources/latest/resources/type/types/ObjectType.ts
diff --git a/...src/api/generated/api/resources/api/resources/latest/resources/type/types/ObjectType.d.ts b/...src/api/generated/api/resources/api/resources/latest/resources/type/types/ObjectType.d.ts