refactor!: cubit extends bloc #2044

felangel · 2020-12-25T20:33:43Z

Status

READY

Breaking Changes

YES

Description

refactor!: cubit extends bloc
refactor!(bloc_test): null safety (Release a null-safe pre-release of bloc_test #2063)

Type of Change

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore

codecov · 2020-12-25T20:37:43Z

Codecov Report

Merging #2044 (569d57d) into null_safety (f22df26) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           null_safety     #2044   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               13        14    +1     
  Lines              219       267   +48     
=============================================
+ Hits               219       267   +48

Impacted Files	Coverage Δ
packages/bloc/lib/src/bloc_observer.dart	`100.00% <ø> (ø)`
packages/bloc/lib/src/transition.dart	`100.00% <ø> (ø)`
...ages/flutter_bloc/lib/src/multi_bloc_listener.dart	`100.00% <ø> (ø)`
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart	`100.00% <ø> (ø)`
...lutter_bloc/lib/src/multi_repository_provider.dart	`100.00% <ø> (ø)`
packages/bloc/lib/src/bloc.dart	`100.00% <100.00%> (ø)`
packages/bloc_test/lib/src/bloc_test.dart	`100.00% <100.00%> (ø)`
packages/bloc_test/lib/src/mock_bloc.dart	`100.00% <100.00%> (ø)`
packages/bloc_test/lib/src/when_listen.dart	`100.00% <100.00%> (ø)`
packages/flutter_bloc/lib/src/bloc_builder.dart	`100.00% <100.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22df26...569d57d. Read the comment docs.

* refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates

jorgecoca · 2021-01-13T19:21:35Z

packages/bloc/lib/src/bloc.dart

+///
+/// _Note: thrown in debug mode only_
+/// {@endtemplate}
+class BlocUnhandledErrorException implements Exception {


* docs: fix typo in fluttertodostutorial.md (#2036) * ci: update docs workflow to use create-an-issue@v2 * refactor!: cubit extends bloc * feat(bloc_test): bloc-base refactor * refactor: update imports * revert: bloc_test changes * refactor: simplify controller initialization and getters * refactor!(bloc_test): null safety (#2067) * refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates * refactor: remove redundant _observer Co-authored-by: Cervon Wong <[email protected]>

* docs: fix typo in fluttertodostutorial.md (felangel#2036) * ci: update docs workflow to use create-an-issue@v2 * refactor!: cubit extends bloc * feat(bloc_test): bloc-base refactor * refactor: update imports * revert: bloc_test changes * refactor: simplify controller initialization and getters * refactor!(bloc_test): null safety (felangel#2067) * refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates * refactor: remove redundant _observer Co-authored-by: Cervon Wong <[email protected]>

felangel added pkg:bloc This issue is related to the bloc package pkg:flutter_bloc This issue is related to the flutter_bloc package breaking change Enhancement candidate would introduce a breaking change refactor Refactor an existing implementation labels Dec 25, 2020

felangel self-assigned this Dec 25, 2020

felangel force-pushed the refactor/bloc-base branch 2 times, most recently from 5480930 to ea103f9 Compare December 30, 2020 04:31

cervonwong and others added 7 commits December 29, 2020 22:32

docs: fix typo in fluttertodostutorial.md (#2036)

534e594

ci: update docs workflow to use create-an-issue@v2

de5d69a

refactor!: cubit extends bloc

a85aacc

feat(bloc_test): bloc-base refactor

de488e4

refactor: update imports

60ff4d3

revert: bloc_test changes

0cff5bb

refactor: simplify controller initialization and getters

3c9f84f

felangel force-pushed the refactor/bloc-base branch from ea103f9 to 3c9f84f Compare December 30, 2020 04:32

felangel mentioned this pull request Jan 12, 2021

refactor!(bloc_test): null safety #2067

Merged

7 tasks

refactor!(bloc_test): null safety (#2067)

5ba2700

* refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates

felangel added pkg:bloc_test This issue is related to the bloc_test package pkg:angular_bloc This issue is related to the angular_bloc package labels Jan 12, 2021

refactor: remove redundant _observer

569d57d

felangel requested a review from jorgecoca January 13, 2021 01:33

felangel marked this pull request as ready for review January 13, 2021 01:33

jorgecoca approved these changes Jan 13, 2021

View reviewed changes

felangel merged commit 8360de4 into null_safety Jan 13, 2021

felangel deleted the refactor/bloc-base branch January 13, 2021 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: cubit extends bloc #2044

refactor!: cubit extends bloc #2044

felangel commented Dec 25, 2020 •

edited

Loading

codecov bot commented Dec 25, 2020 •

edited

Loading

jorgecoca Jan 13, 2021

refactor!: cubit extends bloc #2044

refactor!: cubit extends bloc #2044

Conversation

felangel commented Dec 25, 2020 • edited Loading

Status

Breaking Changes

Description

Type of Change

codecov bot commented Dec 25, 2020 • edited Loading

Codecov Report

jorgecoca Jan 13, 2021

Choose a reason for hiding this comment

felangel commented Dec 25, 2020 •

edited

Loading

codecov bot commented Dec 25, 2020 •

edited

Loading