refactor!(bloc_test): null safety #2067

felangel · 2021-01-09T06:07:20Z

Status

READY

Breaking Changes

YES

Description

refactor!(bloc_test): null safety (Release a null-safe pre-release of bloc_test #2063) (unblocks refactor!: cubit extends bloc #2044)

Type of Change

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore

codecov · 2021-01-09T06:07:25Z

Codecov Report

Merging #2067 (62929cc) into refactor/bloc-base (3c9f84f) will not change coverage.
The diff coverage is 100.00%.

@@                 Coverage Diff                  @@
##           refactor/bloc-base     #2067   +/-   ##
====================================================
  Coverage              100.00%   100.00%           
====================================================
  Files                      11        14    +3     
  Lines                     213       268   +55     
====================================================
+ Hits                      213       268   +55

Impacted Files	Coverage Δ
packages/bloc_test/lib/src/bloc_test.dart	`100.00% <100.00%> (ø)`
packages/bloc_test/lib/src/mock_bloc.dart	`100.00% <100.00%> (ø)`
packages/bloc_test/lib/src/when_listen.dart	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9f84f...62929cc. Read the comment docs.

jorgecoca

LGTM, just had one question

jorgecoca · 2021-01-12T14:20:29Z

examples/flutter_counter/pubspec.yaml


 dev_dependencies:
  flutter_test:
    sdk: flutter
  bloc_test: ^7.1.0
-  mockito: ^4.0.0
+  mocktail: ">=0.0.1-dev.7 <0.1.0"


jorgecoca · 2021-01-12T14:22:40Z

examples/flutter_counter/test/counter/view/counter_view_test.dart

@@ -61,7 +61,7 @@ void main() {
      final decrementFinder = find.byKey(_decrementButtonKey);
      await tester.ensureVisible(decrementFinder);
      await tester.tap(decrementFinder);
-      verify(counterCubit.decrement()).called(1);
+      verify(counterCubit).called(#decrement).once();


Out of curiosity, but I want to make sure we cover all cases: if we use symbols, how can we verify a call with arguments?

For example, if the signature of decrement were void decrement(int value), would you still do 👇 ?

verify(counterCubit).called(#decrement).once();

Yeah that would still work but we can also do:

verify(counterCubit).called(#decrement).withArgs(positional: [any]).once();

* docs: fix typo in fluttertodostutorial.md (#2036) * ci: update docs workflow to use create-an-issue@v2 * refactor!: cubit extends bloc * feat(bloc_test): bloc-base refactor * refactor: update imports * revert: bloc_test changes * refactor: simplify controller initialization and getters * refactor!(bloc_test): null safety (#2067) * refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates * refactor: remove redundant _observer Co-authored-by: Cervon Wong <[email protected]>

* docs: fix typo in fluttertodostutorial.md (felangel#2036) * ci: update docs workflow to use create-an-issue@v2 * refactor!: cubit extends bloc * feat(bloc_test): bloc-base refactor * refactor: update imports * revert: bloc_test changes * refactor: simplify controller initialization and getters * refactor!(bloc_test): null safety (felangel#2067) * refactor!(bloc_test): null safety * ci: use Dart 2.12 * chore: fix tests and bump to mocktail 0.0.1-dev.7 * refactor(bloc_test): minor improvements and documentation updates * refactor: remove redundant _observer Co-authored-by: Cervon Wong <[email protected]>

refactor!(bloc_test): null safety

293fe60

felangel added pkg:bloc_test This issue is related to the bloc_test package breaking change Enhancement candidate would introduce a breaking change refactor Refactor an existing implementation labels Jan 9, 2021

felangel self-assigned this Jan 9, 2021

felangel mentioned this pull request Jan 9, 2021

Release a null-safe pre-release of bloc_test #2063

Closed

felangel added 3 commits January 9, 2021 00:11

ci: use Dart 2.12

9318d27

chore: fix tests and bump to mocktail 0.0.1-dev.7

a023e76

refactor(bloc_test): minor improvements and documentation updates

62929cc

felangel requested a review from jorgecoca January 12, 2021 04:56

felangel marked this pull request as ready for review January 12, 2021 04:56

jorgecoca approved these changes Jan 12, 2021

View reviewed changes

felangel merged commit 5ba2700 into refactor/bloc-base Jan 12, 2021

felangel deleted the refactor/bloc_test-null-safety branch January 12, 2021 15:09

felangel mentioned this pull request Jan 13, 2021

feat!: null safety #1733

Merged

17 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!(bloc_test): null safety #2067

refactor!(bloc_test): null safety #2067

felangel commented Jan 9, 2021 •

edited

Loading

codecov bot commented Jan 9, 2021 •

edited

Loading

jorgecoca left a comment

jorgecoca Jan 12, 2021

jorgecoca Jan 12, 2021

felangel Jan 12, 2021 •

edited

Loading

refactor!(bloc_test): null safety #2067

refactor!(bloc_test): null safety #2067

Conversation

felangel commented Jan 9, 2021 • edited Loading

Status

Breaking Changes

Description

Type of Change

codecov bot commented Jan 9, 2021 • edited Loading

Codecov Report

jorgecoca left a comment

Choose a reason for hiding this comment

jorgecoca Jan 12, 2021

Choose a reason for hiding this comment

jorgecoca Jan 12, 2021

Choose a reason for hiding this comment

felangel Jan 12, 2021 • edited Loading

Choose a reason for hiding this comment

felangel commented Jan 9, 2021 •

edited

Loading

codecov bot commented Jan 9, 2021 •

edited

Loading

felangel Jan 12, 2021 •

edited

Loading