Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites for isogram practice exercise #1578

Merged
merged 5 commits into from
Dec 26, 2021
Merged

Prerequisites for isogram practice exercise #1578

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa96c25
chore: added prerequisites for isogram practice exercise
AnishDe12020 Dec 23, 2021
1a7e3f1
chore: add regular-expressions to prerequisites for isogram exercise
AnishDe12020 Dec 25, 2021
39e6035
refactor: add the prerequisites at the right place for isogram pracit…
AnishDe12020 Dec 25, 2021
7eb41ec
Merge branch 'main' into practice-exercise-prequisities-isogram
junedev Dec 26, 2021
011e564
revert topics update
junedev Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@
"name": "Acronym",
"uuid": "440d78d1-9dea-466f-9bd4-935eed067409",
"practices": [],
"prerequisites": [],
"prerequisites": ["strings", "arrays"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for acronym, I don't understand the selection here. I would have expected strings and regular expressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exercise can be solved without regular expressions (although it will make it a bit longer). Also, I have added arrays because sets are used in the solving of this (my solution as well as top solutions which solve the latest version of the solution use it). I can add regular expressions if required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://exercism.org/tracks/javascript/exercises/isogram/solutions/junedev
https://exercism.org/tracks/javascript/exercises/isogram/solutions/sleeplessbyte

Here are ours.

I did check the first few community solutions, and it seems that each one uses regular expressions. So even though you can solve it without, I think it should be included. The majority of one liners don't use arrays, so I don't think it's a prerequisite to finish the exercise, but I can see how you must be able to "see" the string as an "array of characters" to solve it. I would be okay leaving arrays in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I have added it in 1a7e3f1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnishDe12020 Looks like there is a small mistake. You added something to "topics" which is not used anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a bit confused actually. Nevertheless, I have fixed it in 39e6035. Do let me know if it is fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this comment actually belongs to line 805.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have fixed it there itself.

"difficulty": 2,
"topics": ["loops", "regular_expressions", "strings", "transforming"]
},
Expand All @@ -802,9 +802,9 @@
"name": "Isogram",
"uuid": "3df577af-2854-40ee-b211-9b608dbbad58",
"practices": [],
"prerequisites": [],
"prerequisites": ["strings", "arrays", "regular-expressions"],
"difficulty": 2,
"topics": ["filtering", "strings"]
"topics": ["filtering", "strings", "regular-expressions"]
},
{
"slug": "matching-brackets",
Expand Down