Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerequisites for isogram practice exercise #1578

Merged

Conversation

AnishDe12020
Copy link
Contributor

I have added the prerequisites for the isogram practice exercise.

references #984

@github-actions
Copy link
Contributor

Dear AnishDe12020

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

config.json Outdated
@@ -779,7 +779,7 @@
"name": "Acronym",
"uuid": "440d78d1-9dea-466f-9bd4-935eed067409",
"practices": [],
"prerequisites": [],
"prerequisites": ["strings", "arrays"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for acronym, I don't understand the selection here. I would have expected strings and regular expressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exercise can be solved without regular expressions (although it will make it a bit longer). Also, I have added arrays because sets are used in the solving of this (my solution as well as top solutions which solve the latest version of the solution use it). I can add regular expressions if required.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://exercism.org/tracks/javascript/exercises/isogram/solutions/junedev
https://exercism.org/tracks/javascript/exercises/isogram/solutions/sleeplessbyte

Here are ours.

I did check the first few community solutions, and it seems that each one uses regular expressions. So even though you can solve it without, I think it should be included. The majority of one liners don't use arrays, so I don't think it's a prerequisite to finish the exercise, but I can see how you must be able to "see" the string as an "array of characters" to solve it. I would be okay leaving arrays in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I have added it in 1a7e3f1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnishDe12020 Looks like there is a small mistake. You added something to "topics" which is not used anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a bit confused actually. Nevertheless, I have fixed it in 39e6035. Do let me know if it is fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this comment actually belongs to line 805.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have fixed it there itself.

@junedev junedev added the x:size/small Small amount of work label Dec 23, 2021
@junedev junedev merged commit 73724c3 into exercism:main Dec 26, 2021
@AnishDe12020 AnishDe12020 deleted the practice-exercise-prequisities-isogram branch December 26, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants