-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisites for isogram practice exercise #1578
Prerequisites for isogram practice exercise #1578
Conversation
Dear AnishDe12020Thank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
config.json
Outdated
@@ -779,7 +779,7 @@ | |||
"name": "Acronym", | |||
"uuid": "440d78d1-9dea-466f-9bd4-935eed067409", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["strings", "arrays"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for acronym, I don't understand the selection here. I would have expected strings and regular expressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This exercise can be solved without regular expressions (although it will make it a bit longer). Also, I have added arrays because sets are used in the solving of this (my solution as well as top solutions which solve the latest version of the solution use it). I can add regular expressions if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://exercism.org/tracks/javascript/exercises/isogram/solutions/junedev
https://exercism.org/tracks/javascript/exercises/isogram/solutions/sleeplessbyte
Here are ours.
I did check the first few community solutions, and it seems that each one uses regular expressions. So even though you can solve it without, I think it should be included. The majority of one liners don't use arrays, so I don't think it's a prerequisite to finish the exercise, but I can see how you must be able to "see" the string as an "array of characters" to solve it. I would be okay leaving arrays
in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I have added it in 1a7e3f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnishDe12020 Looks like there is a small mistake. You added something to "topics" which is not used anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a bit confused actually. Nevertheless, I have fixed it in 39e6035. Do let me know if it is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this comment actually belongs to line 805.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I have fixed it there itself.
I have added the prerequisites for the isogram practice exercise.
references #984