Verification plugin: Disable verification when Etherscan is selected and no constructor arguments are provided #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and no constructor arguments are provided
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
|
Should we be a bit more explicit by saying "Etherscan requires constructor arguments" ? |
What do you have in mind? Something like "Please provide the constructor arguments when verifying with Etherscan."? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to improve the user feedback on the verification plugin a little. Etherscan is the only verifier that requires constructor arguments. Before this change, the user could hit the verify button even if no constructor arguments are provided. With this change, the verify button gets disabled if Etherscan is selected and no constructor arguments are provided.