Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix plugin: Disable verification when Etherscan is selected and no constructor arguments provided #1876

Open
manuelwedler opened this issue Jan 29, 2025 · 3 comments
Assignees

Comments

@manuelwedler
Copy link
Contributor

Etherscan is the only verifier that requires constructor arguments for verification. At the moment it is possible to hit the "verify" button even if no constructor arguments are provided. If Etherscan is selected, we can provide better feedback to the user. We should disable the button and show an error message in this case.

@kuzdogan kuzdogan moved this from Triage to Backlog in Sourcify Public Feb 3, 2025
@kuzdogan kuzdogan moved this from Backlog to Sprint - Candidates in Sourcify Public Feb 3, 2025
@manuelwedler manuelwedler moved this from Sprint - Candidates to Sprint - Up Next in Sourcify Public Feb 17, 2025
@manuelwedler manuelwedler self-assigned this Feb 17, 2025
@manuelwedler manuelwedler moved this from Sprint - Up Next to Sprint - In Progress in Sourcify Public Feb 24, 2025
@manuelwedler
Copy link
Contributor Author

Opened a PR for this: ethereum/remix-project#5808

@manuelwedler manuelwedler moved this from Sprint - In Progress to Sprint - Blocked in Sourcify Public Feb 25, 2025
@kuzdogan
Copy link
Member

kuzdogan commented Feb 25, 2025

Looking at the API again, it says it's optional but is it actually required of the contract has constructor arguments? Not really clear to me

https://docs.etherscan.io/api-endpoints/contracts

Image

@manuelwedler
Copy link
Contributor Author

I tried it. It is definitely required if your contract has constructor arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint - Blocked
Development

No branches or pull requests

2 participants