Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Implement 64-bit Solidity VM #12665

Merged
merged 14 commits into from
Oct 30, 2024

fix GetInstruction return value type

1078359
Select commit
Loading
Failed to load commit list.
Merged

cannon: Implement 64-bit Solidity VM #12665

fix GetInstruction return value type
1078359
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

63.62% (-0.38%) compared to d6bda03

View this Pull Request on Codecov

63.62% (-0.38%) compared to d6bda03

Details

Codecov Report

Attention: Patch coverage is 49.01961% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (d6bda03) to head (1078359).

Files with missing lines Patch % Lines
cannon/mipsevm/testutil/mips.go 55.55% 15 Missing and 1 partial ⚠️
cannon/mipsevm/testutil/evm.go 20.00% 7 Missing and 1 partial ⚠️
cannon/mipsevm/exec/memory.go 0.00% 0 Missing and 1 partial ⚠️
cannon/mipsevm/exec/mips_instructions.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12665      +/-   ##
===========================================
- Coverage    63.99%   63.62%   -0.38%     
===========================================
  Files           55       55              
  Lines         4605     4629      +24     
===========================================
- Hits          2947     2945       -2     
- Misses        1475     1502      +27     
+ Partials       183      182       -1     
Files with missing lines Coverage Δ
cannon/mipsevm/testutil/memory.go 77.77% <100.00%> (ø)
cannon/mipsevm/exec/memory.go 80.95% <0.00%> (ø)
cannon/mipsevm/exec/mips_instructions.go 67.17% <66.66%> (+0.34%) ⬆️
cannon/mipsevm/testutil/evm.go 66.94% <20.00%> (-3.86%) ⬇️
cannon/mipsevm/testutil/mips.go 78.82% <55.55%> (-6.25%) ⬇️

... and 1 file with indirect coverage changes