cannon: Implement 64-bit Solidity VM #12665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inphi
force-pushed
the
inphi/mips64-contract
branch
from
7010229 to
7a4d3d2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12665 +/- ##
===========================================
- Coverage 63.99% 63.62% -0.38%
===========================================
Files 55 55
Lines 4605 4629 +24
===========================================
- Hits 2947 2945 -2
- Misses 1475 1502 +27
+ Partials 183 182 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Inphi
force-pushed
the
inphi/mips64-contract
branch
from
7a4d3d2 to
1d8d82e
Compare
- Implements 64-bit Cannon (with multithreading) in MIPS64.sol - Re-enable differential testing for 64-bit VMs
Inphi
force-pushed
the
inphi/mips64-contract
branch
from
1d8d82e to
4046108
Compare
mbaxter
reviewed
Oct 28, 2024
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Syscalls.sol
Outdated
Show resolved
Hide resolved
mbaxter
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Did another pass comparing on/off-chain impls. Left a few more nits which are pretty minor. I think we should probably add a test around the InvalidPC error. I would feel better if we had more differential tests on some of the math, but if you feel strongly we can always follow up with more testing in later PRs.
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/src/cannon/libraries/MIPS64Instructions.sol
Outdated
Show resolved
Hide resolved
mbaxter
approved these changes
Oct 30, 2024
axelKingsley
pushed a commit
that referenced
this pull request
Oct 31, 2024
* cannon: Implement MIPS64Memory.sol * cannon: Implement 64-bit Solidity VM - Implements 64-bit Cannon (with multithreading) in MIPS64.sol - Re-enable differential testing for 64-bit VMs * review comments * check pc for 4-byte alignment * gofmt * update snapshot * address nits; add more add/sub/mult overflow tests * diff test misaligned instruction * fix mul[t] MIPS64.sol emulation * diff fuzz mul operations * fix addiu test case * fix GetInstruction return value type
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* cannon: Implement MIPS64Memory.sol * cannon: Implement 64-bit Solidity VM - Implements 64-bit Cannon (with multithreading) in MIPS64.sol - Re-enable differential testing for 64-bit VMs * review comments * check pc for 4-byte alignment * gofmt * update snapshot * address nits; add more add/sub/mult overflow tests * diff test misaligned instruction * fix mul[t] MIPS64.sol emulation * diff fuzz mul operations * fix addiu test case * fix GetInstruction return value type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new VM smart contract that implements 64-bit Cannon (with multitasking). This is implemented in MIPS64.sol.
Testing
Differential testing of both 64-bit VMs is re-enabled. These tests can be run using
make -C ./cannon test64.These tests include:
These tests don't yet run in CI because there are existing diff tests for the cannon32 build that aren't 64-bit compatible. Fixing those tests and CI integration will be addressed in another PR.
Meta
Fixes #12250