Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: simplify and clean up #19126

Merged
merged 1 commit into from
Jan 9, 2025

all: simplify and clean up

2415c82
Select commit
Loading
Failed to load commit list.
Merged

all: simplify and clean up #19126

all: simplify and clean up
2415c82
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

68.80% (-0.06%) compared to 70a1726

View this Pull Request on Codecov

68.80% (-0.06%) compared to 70a1726

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (70a1726) to head (2415c82).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
server/proxy/grpcproxy/adapter/chan_stream.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
pkg/featuregate/feature_gate.go 88.35% <100.00%> (+0.69%) ⬆️
pkg/report/report.go 94.02% <100.00%> (-0.22%) ⬇️
server/proxy/grpcproxy/adapter/chan_stream.go 55.84% <0.00%> (+0.71%) ⬆️

... and 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19126      +/-   ##
==========================================
- Coverage   68.86%   68.80%   -0.06%     
==========================================
  Files         420      420              
  Lines       35640    35626      -14     
==========================================
- Hits        24543    24512      -31     
- Misses       9679     9687       +8     
- Partials     1418     1427       +9     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1726...2415c82. Read the comment docs.