all: simplify and clean up

[callthingsoff]

This patch modernizes the for-range-loop code to copy a map with
"maps.Clone" and "maps.Copy", also eliminates "copyFloats" with
"slices.Clone".

Also simplify "aggSort" and "sortMap" with slices and maps functions.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

Hi @callthingsoff. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.80%. Comparing base (70a1726) to head (2415c82).
Report is 15 commits behind head on main.

Files with missing lines	Patch %	Lines
server/proxy/grpcproxy/adapter/chan_stream.go	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
pkg/featuregate/feature_gate.go	88.35% <100.00%> (+0.69%)	⬆️
pkg/report/report.go	94.02% <100.00%> (-0.22%)	⬇️
server/proxy/grpcproxy/adapter/chan_stream.go	55.84% <0.00%> (+0.71%)	⬆️

... and 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19126      +/-   ##
==========================================
- Coverage   68.86%   68.80%   -0.06%     
==========================================
  Files         420      420              
  Lines       35640    35626      -14     
==========================================
- Hits        24543    24512      -31     
- Misses       9679     9687       +8     
- Partials     1418     1427       +9     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1726...2415c82. Read the comment docs.

[ivanvc]

/ok-to-test

Test failures

[ivanvc]

Hi @callthingsoff, this looks like a good clean up, but it does have some test failures. Could you address them? Thanks.

[callthingsoff]

Hi @callthingsoff, this looks like a good clean up, but it does have some test failures. Could you address them? Thanks.

Sure, maps.Clone can’t ensure the result is non-nil, I replaced all the possible nil-map-Clone with maps.Copy. PTAL.

[callthingsoff]

/retest-required

[ivanvc]

LGTM. Thanks, @callthingsoff.

[jmhbnz]

LGTM - Thanks @callthingsoff

[serathius]

/ok-to-test

[callthingsoff]

Thanks, it’s already labeled ok-to-test, and the tests have passed.

[ahrtr]

LGTM

Thanks for the cleanup!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, callthingsoff, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment