Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shows correct error message on outgoing link #1530

Merged
merged 9 commits into from
Sep 10, 2024
Merged

feat: shows correct error message on outgoing link #1530

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9426c81
add new api exceptions
justinenerio Jul 24, 2024
7f7ec04
upd
justinenerio Jul 24, 2024
fa6c7e9
upd
justinenerio Jul 24, 2024
8ba8c96
Merge branch 'master' into olp-funds-error
justinenerio Aug 2, 2024
2e019aa
Merge branch 'master' into olp-funds-error
justinenerio Aug 12, 2024
c5fe759
Merge branch 'master' into olp-funds-error
justinenerio Aug 15, 2024
1c189a0
Merge branch 'master' into olp-funds-error
justinenerio Aug 20, 2024
a276101
Merge commit '5ae09074090692d892db7de5d2938357413726b2' into olp-fund…
justinenerio Aug 21, 2024
4062a8d
Merge branch 'olp-funds-error' of https://github.com/espresso-cash/es…
justinenerio Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/espressocash_app/lib/features/outgoing_link_payments/services/olp_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'dart:async';

import 'package:dfunc/dfunc.dart';
import 'package:dio/dio.dart';
import 'package:espressocash_api/espressocash_api.dart';
import 'package:fast_immutable_collections/fast_immutable_collections.dart';
import 'package:get_it/get_it.dart';
Expand All @@ -9,6 +10,7 @@ import 'package:solana/base58.dart';
import 'package:solana/solana.dart';
import 'package:uuid/uuid.dart';

import '../../../utils/errors.dart';
import '../../accounts/auth_scope.dart';
import '../../accounts/models/ec_wallet.dart';
import '../../analytics/analytics_manager.dart';
Expand Down Expand Up @@ -221,10 +223,16 @@ class OLPService implements Disposable {
signature: signature,
),
);
} on Exception {
} on Exception catch (error) {
TxFailureReason reason = TxFailureReason.creatingFailure;

if (error is DioException &&
error.toEspressoCashError() == EspressoCashError.insufficientFunds) {
reason = TxFailureReason.insufficientFunds;
}

return payment.copyWith(
status:
const OLPStatus.txFailure(reason: TxFailureReason.creatingFailure),
status: OLPStatus.txFailure(reason: reason),
);
}
}
Expand Down
Loading