Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shows correct error message on outgoing link #1530

Merged
merged 9 commits into from
Sep 10, 2024
Merged

feat: shows correct error message on outgoing link #1530

merged 9 commits into from
Sep 10, 2024

Conversation

justinenerio
Copy link
Contributor

Changes

  • updates EspressoCashError
  • adds insufficient funds on outgoing link

Related issues

Fixes #1529

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio
Copy link
Contributor Author

can be merged after https://github.com/espresso-cash/ec-backend/pull/79

@justinenerio justinenerio self-assigned this Aug 15, 2024
Merculiar
Merculiar previously approved these changes Aug 15, 2024
View reviewed changes
@justinenerio justinenerio marked this pull request as ready for review August 21, 2024 02:47
@ookami-kb ookami-kb merged commit 1da19d7 into master Sep 10, 2024
8 checks passed
@ookami-kb ookami-kb deleted the olp-funds-error branch September 10, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb ookami-kb approved these changes

@Merculiar Merculiar Merculiar left review comments

@Jaxiii Jaxiii Awaiting requested review from Jaxiii

Assignees

@justinenerio justinenerio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add insufficient funds on links
3 participants
@justinenerio @ookami-kb @Merculiar