-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print exceptions to stderr (ESPTOOL-731) #913
feat: print exceptions to stderr (ESPTOOL-731) #913
Conversation
👋 Welcome Massimiliano-solutiontech, thank you for your first contribution to 📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics. Pull request review and merge process you can expectWe do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
Hello @Massimiliano-solutiontech, Unfortunately, this cannot be merged at this moment, as it is a breaking change. It would require a new major release (v5.0). #888 is a duplicate and it's planned to be done as a part of the next major release.
This sounds like a reasonable solution in the meantime. Would you be interested in doing that as a part of this PR?
Unfortunately, this means it is still a breaking change if the existing scripts have to be changed. |
Yes, in the next few days I'll update this PR Thanks |
Hi @radimkarnis, Now you can redirect errors to
Let me know if the name of the arg fits and/or if the implementation that I did is ok |
Hello @Massimiliano-solutiontech, thanks for the implementation! I will ask you to kindly remove the |
@radimkarnis done |
Hi @Massimiliano-solutiontech, I am sorry to change our opinion, but we have decided not to implement this as a configurable option, because:
I hope you understand that we need to keep the tools as lean as possible because every new option decreases maintainability. Thanks for your work on this, it is appreciated! |
Now the exceptions are printed out in the
stderr
instead ofstdout
. That could be a breaking change for some users so here two considerations:esptool.cfg
stderr
tostdout
by doingesptool.py flash_id &> stdout+stderr.txt
I found this open issue #888 but in my opinion this change can be merged in the current version (
4.7
)