This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
fix(sync-jira-pr): Remove condition "Sync only PRs without comments" #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the problem of unsynchronized PRs from repositories with an active
DangerJS for GitHub
workflow (GH action).Danger for GitHub (bot
github-actions
) almost always creates a comment in a pull request faster than the Jira sync cronjob is triggered. Then the PR is ignored by the sync action because it already contains a comment.If anyone knows of a compelling reason why this should remain unchanged, please explain (in which case we will close this PR and try to approach it differently).
Tested
Danger action
enabled,JIRA PR SYNC
action without changeconclusion:
- didn't synced, created new JIRA ticket when closing comment
- this is what we want to solve by this PR
Danger action
enabled,JIRA PR SYNC
action with changes in this PRconclusion:
- works - synced on cronjob, didn't created new JIRA ticket on comment
- this demonstrates behavior in projects where GH action Danger + GH action JIRA are both present
Danger action
disabled,JIRA PR SYNC
action with changes in this PRconclusion:
- this synced normally (expected), Danger comment doesn't block sync process
- the change implemented by this PR should not affect projects without a Danger GH action
Related