Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

fix(sync-jira-pr): Remove condition "Sync only PRs without comments" #52

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

tomassebestik
Copy link
Member

@tomassebestik tomassebestik commented Aug 29, 2023

This solves the problem of unsynchronized PRs from repositories with an active DangerJS for GitHub workflow (GH action).

Danger for GitHub (bot github-actions) almost always creates a comment in a pull request faster than the Jira sync cronjob is triggered. Then the PR is ignored by the sync action because it already contains a comment.

If anyone knows of a compelling reason why this should remain unchanged, please explain (in which case we will close this PR and try to approach it differently).

Tested

  1. Danger action enabled, JIRA PR SYNC action without change

  2. Danger action enabled, JIRA PR SYNC action with changes in this PR

  3. Danger action disabled, JIRA PR SYNC action with changes in this PR

Related

@tomassebestik tomassebestik self-assigned this Aug 29, 2023
@tomassebestik tomassebestik added bug Something isn't working Type: Bug Bug in github-actions Status: Reviewing Issue is being reviewed and removed bug Something isn't working labels Aug 29, 2023
@suda-morris
Copy link
Collaborator

IIRC, the extra check not pr.comments was added because we found that when a PR is not synced, there are always no user comments. We use this fact to speed up the PR syncing.

Copy link
Collaborator

@radimkarnis radimkarnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@tomassebestik tomassebestik merged commit 80447c4 into master Aug 30, 2023
@tomassebestik tomassebestik added Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Aug 30, 2023
@tomassebestik tomassebestik deleted the fix/jira-sync-pr branch August 30, 2023 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Done Issue is done internally Type: Bug Bug in github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants