Fix byte order in TOTMR register #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdankolendovskyy
force-pushed
the
bugfix/lan867x_register_byte_order
branch
from
f369946 to
dae1eb2
Compare
bogdankolendovskyy
force-pushed
the
bugfix/lan867x_register_byte_order
branch
from
dae1eb2 to
87a2e62
Compare
kostaond
previously approved these changes
Jan 15, 2025
kostaond
reviewed
Jan 15, 2025
kostaond
dismissed
their stale review
Burst timer probably needs to be swapped too.
Commit fixe the byte order in truct that defines TOTMR register and adds padding to prevent possible issues among compilers. Also addresses two typos made in custom_ioctl commands. Closes espressif#48
bogdankolendovskyy
force-pushed
the
bugfix/lan867x_register_byte_order
branch
from
87a2e62 to
28d8a4f
Compare
kostaond
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit fixes the byte order in the struct that defines TOTMR register and adds padding to prevent possible issues among compilers. Also addresses two typos made in custom_ioctl commands.
Closes #48
Description
Fix byte order in
lan867x_plca_totmr_reg_tand add padding tolan867x_plca_***_reg_tstructs to prevent possible undefined behaviour. Fix typos incustom_ioctlcommandsand
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: