Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify size_or_ary contains ints #788

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Specify size_or_ary contains ints #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chaco/plot_graphics_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def __init__(self, size_or_ary, *args, **kw):
scale = kw.pop("dpi", 72.0) / 72.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can assume that size_or_ary is a tuple of ints, we can make the following change instead (IIUC the code correctly) but we can be defensive and go with the changes you propose.

Suggested change
scale = kw.pop("dpi", 72.0) / 72.0
scale = kw.pop("dpi", 72.0) // 72.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's alright with you I think I will leave the current approach, as you mention, to be defensive. The reasoning being that I think scale_ctm can accept floats and size_or_ary is what we specifically want to have integer entries.
I would guess in practice scale will typically be an integer but I am not certain that would always be the case

if type(size_or_ary) in (list, tuple) and len(size_or_ary) == 2:
size_or_ary = (
size_or_ary[0] * scale + 1,
size_or_ary[1] * scale + 1,
int(size_or_ary[0] * scale + 1),
int(size_or_ary[1] * scale + 1),
)

super().__init__(
Expand Down