Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #785
As mentioned in the issue, we can resolve many test suite errors with celiagg by enforcing these be ints. Note that scale itself I think can be a float (e.g. the
scale_ctm
method expects floats as arguments), however,size_or_ary
gets used as a_width
and_height
and is assumed to contain integers.Note, with this change I now see 2 failures in the test suite:EDIT: I only see the one error mentioned on the issue: