Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Request method parameter. #3378

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Cleanup Request method parameter. #3378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68c18e3
Just use default safe=... characters for urlescape
tomchristie Oct 28, 2024
d7c91f9
Cleanup Request method signature
tomchristie Oct 29, 2024
f77117d
Merge branch 'master' into cleanup-method
tomchristie Oct 29, 2024
787e9a2
Merge branch 'master' into cleanup-method
tomchristie Oct 29, 2024
86efecb
Update CHANGELOG.md
tomchristie Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ This release introduces an `httpx.SSLContext()` class and `ssl_context` paramete
* Review URL percent escape sets, based on WHATWG spec. (#3371, #3373)
* Ensure `certifi` and `httpcore` are only imported if required. (#3377)
* Treat `socks5h` as a valid proxy scheme. (#3178)
* Cleanup `Request()` method signature in line with `client.request()` and `httpx.request()`. (#3378)

## 0.27.2 (27th August, 2024)

Expand Down
8 changes: 2 additions & 6 deletions httpx/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def __repr__(self) -> str:
class Request:
def __init__(
self,
method: str | bytes,
method: str,
url: URL | str,
*,
params: QueryParamTypes | None = None,
Expand All @@ -323,11 +323,7 @@ def __init__(
stream: SyncByteStream | AsyncByteStream | None = None,
extensions: RequestExtensions | None = None,
) -> None:
self.method = (
method.decode("ascii").upper()
if isinstance(method, bytes)
else method.upper()
)
self.method = method.upper()
self.url = URL(url) if params is None else URL(url, params=params)
self.headers = Headers(headers)
self.extensions = {} if extensions is None else extensions
Expand Down