Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Request method parameter. #3378

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Cleanup Request method parameter. #3378

merged 5 commits into from
Oct 29, 2024

Conversation

tomchristie
Copy link
Member

The Request() class currently has a method parameter that's out of sync with client.request(...) and httpx.request(...). This is nominally an API change, tho I think it's actually a bugfix in practice.

@tomchristie tomchristie merged commit 6622553 into master Oct 29, 2024
5 checks passed
@tomchristie tomchristie deleted the cleanup-method branch October 29, 2024 15:31
@tomchristie tomchristie mentioned this pull request Nov 15, 2024
@tomchristie tomchristie mentioned this pull request Nov 28, 2024
@karpetrosyan
Copy link
Member

Oh, it seems this change was breaking and affected the compatibility of another library with httpx. It looks like we should take changes that require a major release a bit more seriously.

This kind of change breaks specific versions of other projects, without giving them any chance to avoid it :c

@tomchristie
Copy link
Member Author

tomchristie commented Dec 10, 2024

Thanks @karpetrosyan, good to see type checker checking types.

nominally an API change, tho I think it's actually a bugfix in practice.

Hishel is looking really smart. Most obvious action points...

  • Reintroduce a clear "pinning" note on the httpx README and homepage. This might either recommend ==0.28 or <1.0.
  • Do whatever we can this side communications-wise to help ensure our dependencies are neatly pinned.
  • Ensure future updates have a clear transition approach. (pre-releases might be appropriate.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants