MPI-aware threading defaults #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #197 |
rcoreilly
reviewed
Apr 20, 2023
|
Related: emer/empi#11 |
|
the job submission script should know this.. Also, under SLURM used on many clusters, it automatically sets GOMAXPROCS based on actual allocated number of cores, so this calculation would be off there. Overall, I think it is better to keep it simple in the axon code and leave this to the submission script. |
etuleu
approved these changes
Apr 20, 2023
|
Sorry I wasn't aware there was a conversation still going on and I just approved the PR. Please decide what you want and do it! It's confusing as hell like this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.