Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MPI-aware threading defaults" #200

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

siboehm
Copy link
Member

@siboehm siboehm commented Apr 21, 2023

Reverts #198

I think we were not in agreement on whether it was a good change, so it shouldn't have gotten merged (@etuleu approval triggered the automerger).

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (1c1726b) 40.35% compared to head (5dec39b) 40.34%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   40.35%   40.34%   -0.01%     
==========================================
  Files          53       53              
  Lines       10223    10222       -1     
==========================================
- Hits         4125     4124       -1     
  Misses       5865     5865              
  Partials      233      233              
Impacted Files Coverage Δ
axon/threads.go 60.86% <100.00%> (-0.29%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@siboehm siboehm enabled auto-merge April 22, 2023 15:45
@siboehm siboehm requested a review from rcoreilly April 22, 2023 15:45
Copy link
Member

@rcoreilly rcoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@siboehm siboehm merged commit 7e9561c into master Apr 22, 2023
@siboehm siboehm deleted the revert-198-siboehm/MPIHeuristics branch April 22, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants