feat(#9): add github project scanning support #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scastlara
previously approved these changes
Jan 9, 2025
internal/repository/github/github.go
Outdated
|
|
||
| s := githubService{client: &githubClient{client: client}, token: token} | ||
|
|
||
| return &s, nil |
There was a problem hiding this comment.
copied from the gitlab implementation which can return an error. But here github doesn't return an error, so no need for a pointer!
Changed.
scastlara
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for github repository scanning
What was done:
refactor the
repopackage which only contained gitlab logic to:repository: package which contains all repository-related servicesgitlab: package which contains service to interact with gitlabgithub: package which contains service to interact with githubprovider: package which contains service which "provides" gitlab or github depending on a passed repository typerefactored uses of the gitlab service with the new "providerService" which goes to gitlab or github depending on the type of project
Still in TODO: