chore: change github client creation to value

elementsinteractive · Jan 9, 2025 · 2547e1a · 2547e1a
1 parent 78f8edf
commit 2547e1a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/internal/repository/github/github.go b/internal/repository/github/github.go
@@ -20,12 +20,12 @@ type githubService struct {
 }
 
 // newGithubRepo creates a new GitHub repository service
-func New(token string) (*githubService, error) {
+func New(token string) githubService {
 	client := github.NewClient(nil)
 
 	s := githubService{client: &githubClient{client: client}, token: token}
 
-	return &s, nil
+	return s
 }
 
 func (s githubService) GetProjectList(paths []string) (projects []repository.Project, warn error) {

diff --git a/internal/repository/github/github_test.go b/internal/repository/github/github_test.go
@@ -9,13 +9,6 @@ import (
 	"github.com/stretchr/testify/mock"
 )
 
-func TestNewService(t *testing.T) {
-	s, err := New("token")
-
-	assert.Nil(t, err)
-	assert.NotNil(t, s)
-}
-
 func TestGetProjectListOrganizationRepos(t *testing.T) {
 	mockService := mockService{}
 	mockService.On("GetOrganizationRepositories", "org", mock.Anything).Return([]*github.Repository{{Name: github.Ptr("Hello World")}}, &github.Response{}, nil)

diff --git a/internal/repository/provider/provider.go b/internal/repository/provider/provider.go
@@ -24,10 +24,7 @@ func NewProvider(gitlabToken string, githubToken string) (IProvider, error) {
 		return nil, errors.Join(fmt.Errorf("failed to create gitlab provider"), err)
 	}
 
-	githubService, err := github.New(githubToken)
-	if err != nil {
-		return nil, errors.Join(fmt.Errorf("failed to create github provider"), err)
-	}
+	githubService := github.New(githubToken)
 
 	return provider{
 		gitlabService: gitlabService,