Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2544] Clean up package code before publishing; remove lots of unused code #439

Merged
merged 18 commits into from
Dec 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format and disable cspell for emoji names
xbtmatt committed Dec 5, 2024
commit 4ba6e3089fd16dc7df86140ad6204a257afe2406
2 changes: 1 addition & 1 deletion src/typescript/sdk/src/emoji_data/README.md
Original file line number Diff line number Diff line change
@@ -29,5 +29,5 @@ const SYMBOL_EMOJIS = {
} as const;
```

Note the ` as const;` at the end of the object. It _must_ be there for the types
Note the `as const;` at the end of the object. It _must_ be there for the types
to be resolved correctly.
2 changes: 2 additions & 0 deletions src/typescript/sdk/src/emoji_data/chat-emojis.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// cspell:disable

export const CHAT_EMOJIS = {
"🧑‍🎨": "artist",
"🧑🏿‍🎨": "artist: dark skin tone",
2 changes: 2 additions & 0 deletions src/typescript/sdk/src/emoji_data/symbol-emojis.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// cspell:disable

export const SYMBOL_EMOJIS = {
"🥇": "1st place medal",
"🥈": "2nd place medal",
2 changes: 1 addition & 1 deletion src/typescript/sdk/tests/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "../tsconfig.json",
"compilerOptions": {
"noEmit": true
},
"extends": "../tsconfig.json",
"include": [
"./**/*"
]
19 changes: 15 additions & 4 deletions src/typescript/sdk/tsconfig.json
Original file line number Diff line number Diff line change
@@ -9,7 +9,11 @@
"experimentalDecorators": true,
"forceConsistentCasingInFileNames": true,
"isolatedModules": true,
"lib": ["dom", "dom.iterable", "esnext"],
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"module": "esnext",
"moduleDetection": "force",
"moduleResolution": "bundler",
@@ -22,8 +26,15 @@
"sourceMap": true,
"strict": true,
"target": "esnext",
"types": ["node", "jest"]
"types": [
"node",
"jest"
]
},
"exclude": ["node_modules"],
"include": ["src"]
"exclude": [
"node_modules"
],
"include": [
"src"
]
}
2 changes: 1 addition & 1 deletion src/typescript/sdk/tsconfig.prod.json
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
"extends": "./tsconfig.json",
"compilerOptions": {
"noEmit": false,
"outDir": "./dist",
"outDir": "./dist"
},
"exclude": ["node_modules", "**/*.test.ts", "**/*.spec.ts", "tests/e2e/**/*", "tests/unit/**/*"],
"include": ["src", "dist"]