Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-2544] Clean up package code before publishing; remove lots of unused code #439

Merged
merged 18 commits into from
Dec 5, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Dec 4, 2024

Description

  • Output emojis as a typescript file directly, cleans up our ts base and reduces packed size by ~20kb
  • Ensure the emojis are written to the *-emojis.ts (chat/symbol) files as emojis, not \u0123 encoded strings
  • Exclude tests from the final build
  • Move test utils to the tests folder
  • add a prepublish command
  • Remove lots of unused code (I manually combed through the whole SDK)
  • Separated tsconfig.json to have a .prod. version that's solely for publishing
  • Added prepublishOnly (only run on publish)
  • Added back in dist folder- that's just a thing for axios because tons of people download Axios through a CDN on GitHub at runtime rather than building the package. No one is going to be downloading our SDK with a CDN instead of just building it into their frontend. The diff in our repo will be a huge mess, so I've excluded it again
  • Remove mqtt.ts

Testing

SDK tests. I've almost entirely removed functions outright- I didn't alter any intra-function code, so everything should continue to work if the SDK continues to build.

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@xbtmatt xbtmatt requested a review from CRBl69 December 4, 2024 08:26
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:22pm
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:22pm

@xbtmatt xbtmatt marked this pull request as draft December 4, 2024 08:28
@xbtmatt xbtmatt force-pushed the ECO-2485 branch 3 times, most recently from 1920dd4 to 0f3e3af Compare December 4, 2024 22:41
Base automatically changed from ECO-2485 to main December 4, 2024 23:22
@xbtmatt xbtmatt marked this pull request as ready for review December 4, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants