-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-2544] Clean up package code before publishing; remove lots of unused code #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xbtmatt
force-pushed
the
ECO-2485
branch
3 times, most recently
from
December 4, 2024 22:41
1920dd4
to
0f3e3af
Compare
CRBl69
approved these changes
Dec 5, 2024
Re-organize exports for server/indexer exports
Bump version for rc
xbtmatt
added a commit
that referenced
this pull request
Dec 11, 2024
4 tasks
alnoki
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Bogdan Crisan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
*-emojis.ts
(chat/symbol) files as emojis, not\u0123
encoded stringstests
foldertsconfig.json
to have a.prod.
version that's solely for publishingprepublishOnly
(only run on publish)dist
folder- that's just a thing foraxios
because tons of people download Axios through a CDN on GitHub at runtime rather than building the package. No one is going to be downloading our SDK with a CDN instead of just building it into their frontend. The diff in our repo will be a huge mess, so I've excluded it againmqtt.ts
Testing
SDK tests. I've almost entirely removed functions outright- I didn't alter any intra-function code, so everything should continue to work if the SDK continues to build.
Checklist