Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ecal_sys] Fix for startup bug when applications are not callable #1989

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/sys/sys_core/src/connection/remote_connection.cpp
Original file line number Diff line number Diff line change
@@ -128,7 +128,14 @@ namespace eCAL
std::lock_guard<decltype(connection_mutex_)> connection_lock(connection_mutex_);

eCAL::v5::ServiceResponseVecT service_response_vec;
constexpr int timeout_ms = 1000;

// We changed timeout value, as with the new v6 implementation the behaviour changed.
// Now, when there are applications in the list that are not available/cannot be called,
// all apps on this host become failed, however if the app was reachable, it was started.
// The -1 prevents this from happening, so the call gets recognized for each application
// as expected.
// Timeout happens in ecal_service_client_impl.cpp in method CallMethodWithTimeout(...).
constexpr int timeout_ms = -1;

// After client creation it takes some time for the client to be actually connected.
// As the call and the creation is too close together, the first call will fail.