[ecal_sys] Fix for startup bug when applications are not callable #1989
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When starting applications in ecal_sys, it happens that if an application is not available on the host, all other applications that are available on the host are shown as "failed". But they are proper started. You can find and close them through the cloud search.
The problem is, that all calls timeout when setting the timeout parameter too low. With this fix, the timeout is set to infinite, so the call will happen, while the calls to the missing application are proper recognized as "failed".
Increasing this timeout to 6-7 seconds also had the wanted effect.
This seems to be a fix for a symptom, not the cause. As this whole handling needs to be changed to the v6 implementation, it might be different then and for right now we will get the wanted behaviour with this fix.