Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #556 #1061

Merged
merged 8 commits into from
Feb 20, 2025
Merged

fix #556 #1061

merged 8 commits into from
Feb 20, 2025

Conversation

mattansb
Copy link
Member

@mattansb mattansb commented Jan 8, 2025

Fixes #556

@strengejacke
Copy link
Member

Shouldn't these two elements have the same numbers?

mod1 <- aov(yield ~ N * P * K + Error(block), npk)

out1 <- parameters::model_parameters(
  mod1,
  eta_squared = "partial",
  ci = 0.95,
  table_wide = FALSE
)

out2 <- parameters::model_parameters(
  mod1,
  eta_squared = "partial",
  ci = 0.95,
  table_wide = TRUE
)

out1$Mean_Square[out1$Parameter == "Residuals"]
#> [1] 76.57333 15.44056
out2$Mean_Square_Error
#> [1] 306.2933 185.2867 185.2867 185.2867 185.2867 185.2867 185.2867

Created on 2025-01-08 with reprex v2.1.1

@mattansb
Copy link
Member Author

mattansb commented Jan 8, 2025

Oops, you're right! I'll take a look.

@strengejacke
Copy link
Member

GitHub action going weird atm?

@strengejacke strengejacke merged commit 23d3b07 into main Feb 20, 2025
0 of 23 checks passed
@strengejacke strengejacke deleted the fix-table_wide branch February 20, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table_wide fails with more complex error structures in aov objects
2 participants