feat: cctp withdrawals: withdraw form [OTE-855][5/n] #1155

yogurtandjam · 2024-10-15T23:44:10Z

Adds the withdrawform component and hooks it up to the subcomponents in the stack

Adds ArrowIcon and USDCIcon

Adds backgroundColorOverride to formInput and Input components to enable dark themed

TODOS:

calculate default withdrawal address for keplr wallets
transfer status notifications
optimize useTransfers
coinbase withdrawals
replace testflag with statsig feature flagging

Figma https://www.figma.com/design/fMQodZKzn9B5aZTN5G0fLJ/dYdX-%E2%80%BA-Web?node-id=41402-168816&node-type=frame&t=HtXCnIXhOiY4jfOY-0

What it actually looks like
https://www.loom.com/share/c7904c9fd90a4bd6a921257cd81f5461?sid=66851029-b82e-4e93-a34e-f33822f1bdb5

linear · 2024-10-15T23:44:14Z

OTE-855 CCTP Withdrawals

vercel · 2024-10-15T23:44:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 7:36pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 22, 2024 7:36pm

src/components/Input.tsx

tyleroooo · 2024-10-22T15:54:52Z

src/views/dialogs/WithdrawDialog.tsx

+        testFlags.onboardingRewrite ? (
+          <span tw="row gap-[0.5ch]">
+            <Icon iconName={IconName.Usdc} size="1.5em" />
+            {stringGetter({ key: STRING_KEYS.WITHDRAW })} USDC


usdc needs to be a parameter, can't guarantee all languages put object after verb

oh good point, this should have the localize TODO on it. i just haven't been localizing any of these strings yet.

tyleroooo · 2024-10-22T16:01:44Z

src/views/forms/AccountManagementFormsNew/WithdrawForm/WithdrawForm.tsx

+    return (
+      <$Form onSubmit={onSubmit}>
+        <div tw="text-color-text-0">
+          Make sure everything looks correct with your withdrawal before confirming


tyleroooo · 2024-10-22T16:02:17Z

src/views/forms/AccountManagementFormsNew/WithdrawForm/WithdrawForm.tsx

+          </span>
+        }
+        validationConfig={
+          toAddress && Boolean(exchange) && !isValidDestinationAddress


I prefer !!exchange but this works too

hmmm okay i'm down. tbh i've always preferred Boolean but i think !! is more common at this company so it makes sense to match that pattern

tyleroooo · 2024-10-22T16:03:17Z

src/views/forms/AccountManagementFormsNew/WithdrawForm/WithdrawForm.tsx

+          />
+        }
+      />
+      <ArrowContainer tw="z-1 mx-auto -mb-1.25 -mt-1.25 flex h-1.5 w-1.5 items-center justify-center rounded-0.25 border-color-layer-7 bg-color-layer-4">


this one is probably at the point it's better as a styled component. Why the "-" in front of mb and mt?

negative margins to allow for overlapping components

still somewhat prefer this being a styled component but it's not a big deal

src/views/forms/AccountManagementFormsNew/WithdrawForm/WithdrawForm.tsx

src/hooks/transfers/useTransfers.tsx

… still exist

tyleroooo

i didn't re-review, assuming the pr that just came in was reviewed

vercel bot had a problem deploying to Preview – v4-testnet October 15, 2024 23:52 Failure

vercel bot had a problem deploying to Preview – v4-staging October 15, 2024 23:53 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-4 branch 2 times, most recently from 6cb13aa to c3ad6a0 Compare October 16, 2024 00:56

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch 2 times, most recently from f91234c to e3e08cf Compare October 16, 2024 00:57

vercel bot had a problem deploying to Preview – v4-testnet October 16, 2024 00:59 Failure

vercel bot had a problem deploying to Preview – v4-staging October 16, 2024 00:59 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-4 branch from c3ad6a0 to 5504986 Compare October 16, 2024 01:05

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch from e3e08cf to 01d41ae Compare October 16, 2024 18:47

vercel bot had a problem deploying to Preview – v4-staging October 16, 2024 18:48 Failure

vercel bot had a problem deploying to Preview – v4-testnet October 16, 2024 18:48 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-4 branch from 5504986 to ed6d288 Compare October 16, 2024 21:14

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch 2 times, most recently from 4ee597b to 76a7484 Compare October 16, 2024 21:15

vercel bot had a problem deploying to Preview – v4-staging October 16, 2024 21:23 Failure

vercel bot had a problem deploying to Preview – v4-testnet October 16, 2024 21:23 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch from 9792997 to 3e09292 Compare October 17, 2024 17:00

vercel bot had a problem deploying to Preview – v4-testnet October 17, 2024 17:01 Failure

vercel bot had a problem deploying to Preview – v4-staging October 17, 2024 17:02 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch 3 times, most recently from 9486824 to 762e73e Compare October 17, 2024 17:21

vercel bot had a problem deploying to Preview – v4-staging October 17, 2024 17:25 Failure

vercel bot had a problem deploying to Preview – v4-testnet October 17, 2024 17:26 Failure

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-4 branch from ed6d288 to 8de27cd Compare October 17, 2024 19:34

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch from 762e73e to 4f8cb71 Compare October 17, 2024 19:36

vercel bot deployed to Preview – v4-staging October 17, 2024 19:50 View deployment

vercel bot deployed to Preview – v4-staging October 21, 2024 20:39 View deployment

vercel bot deployed to Preview – v4-testnet October 21, 2024 20:39 View deployment

vercel bot deployed to Preview – v4-testnet October 21, 2024 21:57 View deployment

vercel bot deployed to Preview – v4-staging October 21, 2024 21:57 View deployment

tinaszheng mentioned this pull request Oct 21, 2024

feat: calculate withdrawal address for keplr [OTE-875] #1182

Merged

tyleroooo reviewed Oct 22, 2024

View reviewed changes

yogurtandjam commented Oct 22, 2024

View reviewed changes

src/hooks/transfers/useTransfers.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview – v4-staging October 22, 2024 16:45 View deployment

vercel bot deployed to Preview – v4-testnet October 22, 2024 16:46 View deployment

tyleroooo approved these changes Oct 22, 2024

View reviewed changes

yogurtandjam and others added 13 commits October 22, 2024 14:31

feat: cctp withdrawals: withdraw form [OTE-855][5/n]

e059e8e

withdrawal mcdal ui!

93e841a

cleanup

373fe11

add loading state

90bf4f5

fix revert/rebase issue lol

564167f

revert skip client changes so it remains unused. bundle size problems…

85befd2

… still exist

add $ styleprop prefix for styled component props

9a65f74

correct import name

83e077c

better file naming. fix error

5a5ea90

flag dialog name

b197215

extract tw to styled component. remove useless usecallbacks. add TODOs

f4005cd

feat: calculate withdrawal address for keplr [OTE-875] (#1182)

4235a3c

outdated comment

1411437

yogurtandjam force-pushed the jerms/OTE-855_cctp-withdrawals-5 branch from 393f229 to 1411437 Compare October 22, 2024 19:32

vercel bot deployed to Preview – v4-staging October 22, 2024 19:36 View deployment

vercel bot deployed to Preview – v4-testnet October 22, 2024 19:36 View deployment

tyleroooo approved these changes Oct 22, 2024

View reviewed changes

yogurtandjam merged commit 0c048df into main Oct 22, 2024
9 checks passed

yogurtandjam deleted the jerms/OTE-855_cctp-withdrawals-5 branch October 22, 2024 22:43

rosepuppy pushed a commit that referenced this pull request Oct 24, 2024

feat: cctp withdrawals: withdraw form [OTE-855][5/n] (#1155)

e6b8258

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cctp withdrawals: withdraw form [OTE-855][5/n] #1155

feat: cctp withdrawals: withdraw form [OTE-855][5/n] #1155

yogurtandjam commented Oct 15, 2024 •

edited

Loading

linear bot commented Oct 15, 2024

vercel bot commented Oct 15, 2024 •

edited

Loading

tyleroooo Oct 22, 2024

yogurtandjam Oct 22, 2024

tyleroooo Oct 22, 2024

tyleroooo Oct 22, 2024

yogurtandjam Oct 22, 2024

tyleroooo Oct 22, 2024

yogurtandjam Oct 22, 2024

tyleroooo Oct 22, 2024

tyleroooo left a comment

feat: cctp withdrawals: withdraw form [OTE-855][5/n] #1155

feat: cctp withdrawals: withdraw form [OTE-855][5/n] #1155

Conversation

yogurtandjam commented Oct 15, 2024 • edited Loading

linear bot commented Oct 15, 2024

vercel bot commented Oct 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tyleroooo left a comment

Choose a reason for hiding this comment

yogurtandjam commented Oct 15, 2024 •

edited

Loading

vercel bot commented Oct 15, 2024 •

edited

Loading