feat: calculate withdrawal address for keplr [OTE-875] #1182
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
force-pushed
the
jerms/OTE-855_cctp-withdrawals-5
branch
from
db49c26 to
d9bdba0
Compare
| // Cosmos chains connect to the keplr wallet, which has a unique address per chain id | ||
| const calculatedCosmosAddress = toChainId && cosmosChainAddresses[toChainId]; | ||
| setToAddress(calculatedCosmosAddress ?? sourceAccount.address); |
There was a problem hiding this comment.
hmm so instead of setting all of these initial values in a useEffect, these can just be initialized as initial state in useTransfer
There was a problem hiding this comment.
👍 absolutely agree, i had a comment somewhere about doing this but it probably got lost.
i have a ticket here: https://linear.app/dydx/issue/OTE-869/optimize-usetransfers to track this work
ideally rn would like to separate PR's by goal though. i feel like once all the functionality is in it will be easier to write the best pattern to optimize this, rather than trying to guess what it should all look like before we have all the features in.
i'll add a TODO comment with this ticket linked to make sure we take care of this if that works for you
There was a problem hiding this comment.
hmm you could probably do in #1155 directly since that's where you create the WithdrawForm
There was a problem hiding this comment.
i was hoping to start the deposit form first - cause i think it actually might make the most sense to split the useTransfers hook into useWithdrawals useDeposits so we don't have to flag everything on TransferType but i'd want to work through all the gotchas and usecases first to make sure it's the proper refactor
yogurtandjam
force-pushed
the
jerms/OTE-855_cctp-withdrawals-5
branch
from
d9bdba0 to
1c9a301
Compare
yogurtandjam
force-pushed
the
jerms/OTE-875_default-withdrawal-address-keplr
branch
from
390c372 to
8d9c4c6
Compare
yogurtandjam
force-pushed
the
jerms/OTE-855_cctp-withdrawals-5
branch
from
954593e to
dec2128
Compare
yogurtandjam
force-pushed
the
jerms/OTE-875_default-withdrawal-address-keplr
branch
from
3e84f19 to
65178fc
Compare
yogurtandjam
force-pushed
the
jerms/OTE-875_default-withdrawal-address-keplr
branch
from
65178fc to
c8dca3d
Compare
yogurtandjam
merged commit 49f53db
into
jerms/OTE-855_cctp-withdrawals-5
yogurtandjam
deleted the
jerms/OTE-875_default-withdrawal-address-keplr
branch
move cosmosChainAddresses to useMemo and export it from useTransfers hook
use cosmosChainAddresses to calculate cosmos address.
if we dont receive an address from cosmosChainAddresses, then we're not connected to keplr