Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Adding env variables to deploy workflow so compile_env works. #102

Merged
merged 11 commits into from
Jul 19, 2023
Merged

[PR] Adding env variables to deploy workflow so compile_env works. #102

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4f751dd
fix: Adding env variables to deploy workflow so `compile_env` works.
LuchoTurtle Jul 19, 2023
de66d3a
chore: Enabling on PRs just to test.
LuchoTurtle Jul 19, 2023
dae4626
fix: Making compile_env fetcheable as runtime envs.
LuchoTurtle Jul 19, 2023
3e1aa69
chore: Testing if using only runtime variables work.
LuchoTurtle Jul 19, 2023
cd2c0d8
Revert "chore: Testing if using only runtime variables work."
LuchoTurtle Jul 19, 2023
dd4b1ec
chore: Small refactor of envs in upload/1 to get rid of warnings.
LuchoTurtle Jul 19, 2023
c1f39ea
chore: Fix typo.
LuchoTurtle Jul 19, 2023
42fad50
chore: Deploy only on main pushes.
LuchoTurtle Jul 19, 2023
98e78ee
chore: Testing deploy fly without env in workflow file.
LuchoTurtle Jul 19, 2023
7babb19
chore: Finished testing.
LuchoTurtle Jul 19, 2023
98c394e
split compressed_baseurl into cached function #102
nelsonic Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/fly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
push:
branches:
- main
pull_request:
branches: [ main ]
jobs:
deploy:
name: Deploy app
Expand All @@ -14,4 +16,7 @@ jobs:
- uses: superfly/flyctl-actions/setup-flyctl@master
- run: flyctl deploy --remote-only
env:
FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
AWS_REGION: eu-west-3
LuchoTurtle marked this conversation as resolved.
Show resolved Hide resolved
AWS_S3_BUCKET_ORIGINAL: imgup-original
AWS_S3_BUCKET_COMPRESSED: imgup-compressed
5 changes: 5 additions & 0 deletions api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,11 @@ making it simpler!


```elixir

@original_bucket Application.get_env(:ex_aws, :original_bucket)
@compressed_bucket Application.get_env(:ex_aws, :compressed_bucket)
@compressed_baseurl "https://s3.eu-west-3.amazonaws.com/#{@compressed_bucket}/"

def upload(image) do
with {:ok, {file_cid, file_extension}} <- check_file_binary_and_extension(image),
{:ok, {file_name, upload_response_body}} <-
Expand Down
4 changes: 2 additions & 2 deletions lib/app/upload.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ defmodule App.Upload do
import SweetXml
require Logger

@original_bucket Application.compile_env(:ex_aws, :original_bucket)
@compressed_bucket Application.compile_env(:ex_aws, :compressed_bucket)
@original_bucket Application.get_env(:ex_aws, :original_bucket)
@compressed_bucket Application.get_env(:ex_aws, :compressed_bucket)
nelsonic marked this conversation as resolved.
Show resolved Hide resolved
@compressed_baseurl "https://s3.eu-west-3.amazonaws.com/#{@compressed_bucket}/"

@doc """
Expand Down